Skip to content

Documentation for Foldable1 doesn't state which combinations of default implementations are unsafe to use together #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
triallax opened this issue Jul 13, 2020 · 0 comments · Fixed by #128
Labels
type: enhancement A new feature or addition.

Comments

@triallax
Copy link
Contributor

Quote from the Foldable1 class documentation:

Note: some combinations of the default implementations are unsafe to use together - causing a non-terminating mutually recursive cycle. These combinations are documented per function.

However, the docs for fold1Default and foldMap1Default state nothing about this. Reading the source code of those functions, it is clear that both are unsafe to use together.

@garyb garyb added the type: enhancement A new feature or addition. label Jul 15, 2020
@triallax triallax changed the title Documentation for Foldable1 doesn't which combinations of default implementations are unsafe to use together Documentation for Foldable1 doesn't state which combinations of default implementations are unsafe to use together Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A new feature or addition.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants