From 0545ca338efcbac62e759eb812eaed3e476753c7 Mon Sep 17 00:00:00 2001 From: Jordan Martinez Date: Thu, 17 Mar 2022 08:39:51 -0500 Subject: [PATCH 1/3] Drop deprecated group' and empty --- src/Data/Array.purs | 5 ----- src/Data/Array/NonEmpty.purs | 5 ----- src/Data/Array/ST.purs | 4 ---- 3 files changed, 14 deletions(-) diff --git a/src/Data/Array.purs b/src/Data/Array.purs index d3295941..4778025e 100644 --- a/src/Data/Array.purs +++ b/src/Data/Array.purs @@ -100,7 +100,6 @@ module Data.Array , span , group , groupAll - , group' , groupBy , groupAllBy @@ -983,10 +982,6 @@ group xs = groupBy eq xs groupAll :: forall a. Ord a => Array a -> Array (NonEmptyArray a) groupAll = groupAllBy compare --- | Deprecated previous name of `groupAll`. -group' :: forall a. Warn (Text "'group\'' is deprecated, use 'groupAll' instead") => Ord a => Array a -> Array (NonEmptyArray a) -group' = groupAll - -- | Group equal, consecutive elements of an array into arrays, using the -- | specified equivalence relation to determine equality. -- | diff --git a/src/Data/Array/NonEmpty.purs b/src/Data/Array/NonEmpty.purs index 67cca9e3..11128901 100644 --- a/src/Data/Array/NonEmpty.purs +++ b/src/Data/Array/NonEmpty.purs @@ -80,7 +80,6 @@ module Data.Array.NonEmpty , span , group , groupAll - , group' , groupBy , groupAllBy @@ -424,10 +423,6 @@ group = unsafeAdapt $ A.group groupAll :: forall a. Ord a => NonEmptyArray a -> NonEmptyArray (NonEmptyArray a) groupAll = groupAllBy compare --- | Deprecated previous name of `groupAll`. -group' :: forall a. Warn (Text "'group\'' is deprecated, use 'groupAll' instead") => Ord a => NonEmptyArray a -> NonEmptyArray (NonEmptyArray a) -group' = unsafeAdapt $ A.groupAll - -- | Group equal, consecutive elements of an array into arrays, using the -- | specified equivalence relation to determine equality. -- | diff --git a/src/Data/Array/ST.purs b/src/Data/Array/ST.purs index 2726dd24..af2d1050 100644 --- a/src/Data/Array/ST.purs +++ b/src/Data/Array/ST.purs @@ -8,7 +8,6 @@ module Data.Array.ST , run , withArray , new - , empty , peek , poke , modify @@ -80,9 +79,6 @@ foreign import unsafeThaw :: forall h a. Array a -> ST h (STArray h a) -- | Create a new, empty mutable array. foreign import new :: forall h a. ST h (STArray h a) -empty :: forall h a. Warn (Text "'Data.Array.ST.empty' is deprecated, use 'Data.Array.ST.new' instead") => ST h (STArray h a) -empty = new - -- | Create a mutable copy of an immutable array. foreign import thaw :: forall h a. Array a -> ST h (STArray h a) From deda6a5d4bc3339b67e4f55dcb2fc796f1cb4fbb Mon Sep 17 00:00:00 2001 From: Jordan Martinez Date: Thu, 17 Mar 2022 08:40:54 -0500 Subject: [PATCH 2/3] Add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 02634881..bb4a1851 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ Notable changes to this project are documented in this file. The format is based Breaking changes: - Migrate FFI to ES modules (#218 by @kl0tl and @JordanMartinez) +- Drop deprecated `group'` and `empty` (#219 by @JordanMartinez) New features: From b2454685def34232555567890fd654d344a48cb8 Mon Sep 17 00:00:00 2001 From: Jordan Martinez Date: Thu, 17 Mar 2022 09:03:27 -0500 Subject: [PATCH 3/3] Drop redundant prim imports --- src/Data/Array.purs | 1 - src/Data/Array/NonEmpty.purs | 1 - src/Data/Array/ST.purs | 1 - 3 files changed, 3 deletions(-) diff --git a/src/Data/Array.purs b/src/Data/Array.purs index 4778025e..6bc035ab 100644 --- a/src/Data/Array.purs +++ b/src/Data/Array.purs @@ -147,7 +147,6 @@ import Data.Traversable (sequence, traverse) import Data.Tuple (Tuple(..), fst, snd) import Data.Unfoldable (class Unfoldable, unfoldr) import Partial.Unsafe (unsafePartial) -import Prim.TypeError (class Warn, Text) -- | Convert an `Array` into an `Unfoldable` structure. toUnfoldable :: forall f. Unfoldable f => Array ~> f diff --git a/src/Data/Array/NonEmpty.purs b/src/Data/Array/NonEmpty.purs index 11128901..332cd695 100644 --- a/src/Data/Array/NonEmpty.purs +++ b/src/Data/Array/NonEmpty.purs @@ -133,7 +133,6 @@ import Data.Tuple (Tuple(..)) import Data.Unfoldable (class Unfoldable) import Data.Unfoldable1 (class Unfoldable1, unfoldr1) import Partial.Unsafe (unsafePartial) -import Prim.TypeError (class Warn, Text) import Unsafe.Coerce (unsafeCoerce) -- | Internal - adapt an Array transform to NonEmptyArray diff --git a/src/Data/Array/ST.purs b/src/Data/Array/ST.purs index af2d1050..2817bee6 100644 --- a/src/Data/Array/ST.purs +++ b/src/Data/Array/ST.purs @@ -33,7 +33,6 @@ import Prelude import Control.Monad.ST as ST import Control.Monad.ST (ST, Region) import Data.Maybe (Maybe(..)) -import Prim.TypeError (class Warn, Text) -- | A reference to a mutable array. -- |