Skip to content

Add missing groupBy' #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ad-si opened this issue May 20, 2018 · 3 comments · Fixed by #194
Closed

Add missing groupBy' #141

ad-si opened this issue May 20, 2018 · 3 comments · Fixed by #194

Comments

@ad-si
Copy link

ad-si commented May 20, 2018

In accordance to group' it should first sort the Array and then group it.

Btw: Why not name it sortAndGroup or sortGroup or groupSort or anything more intuitive then group'? ^^
@hdgarrood
Copy link
Contributor

I'm in favour of renaming group'. Although, as I understand it, the sorting is sort of an implementation detail -- I think this function is best described as a function which groups elements like group does, except that elements are not required to be consecutive in the array in order to be grouped together. So maybe groupNonconsecutive or groupUnordered or something?

@ad-si
Copy link
Author

ad-si commented May 20, 2018

Yeah, good point! Or maybe groupTotal?

@ad-si
Copy link
Author

ad-si commented May 20, 2018

Or still simpler: groupAll

@thomashoneyman thomashoneyman mentioned this issue Nov 10, 2020
Closed
57 tasks
@kl0tl kl0tl mentioned this issue Dec 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename group' to groupAll and add groupAllBy kl0tl/purescript-arrays
2 participants
@hdgarrood @ad-si