Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

uBlock on Sidebar #157

Closed
PressJump opened this issue Nov 18, 2022 · 6 comments · Fixed by #238
Closed

uBlock on Sidebar #157

PressJump opened this issue Nov 18, 2022 · 6 comments · Fixed by #238
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@PressJump
Copy link
Member

Currently uBlock does not affect the sidebar.

Made for tracking purposes to be done after #146.

@PressJump PressJump self-assigned this Nov 18, 2022
@PressJump PressJump added the bug Something isn't working label Nov 18, 2022
@PressJump
Copy link
Member Author

I believe this will need a great amount of investigation and modification, so pushing back until PR #159 and PR #165

@PressJump
Copy link
Member Author

Investigating the issue for adblock application on sidebar browser.

@github-project-automation github-project-automation bot moved this to Trilage in Pulse Browser Jan 8, 2023
@trickypr trickypr moved this from Trilage to TODO: Alpha in Pulse Browser Jan 8, 2023
@PressJump
Copy link
Member Author

Unfortunately I am not too sure if this is possible in the time frame we have. I have tried many ways of enabling the effects of uBlock on the sidebar views but the documentation being older than me does not help. I am tagging this as help needed.

@PressJump PressJump added the help wanted Extra attention is needed label Feb 3, 2023
@garry-ut99
Copy link

In XUL was possible ==> In WebExtensions not anymore : gorhill/uBlock#2995 ==> In MV3 possible again, but declarativeNetRequest API is not yet available in the current implementation of MV3 in Firefox:
uBlockOrigin/uBlock-issues#2524 (comment) +
uBlockOrigin/uBlock-issues#2524 (comment) +
uBlockOrigin/uBlock-issues#2524 (comment)

@surapunoyousei
Copy link
Contributor

Hi, @PressJump

Floorp has same problem. but, I could understand the cause.

Well, many addons need "tab" permission. However, it turns out that this doesn't work for normal browser elements or panels inside sidebars.

The solution is to embed "chrome://browser/content/browser.xhtml" but unfortunately it's almost certain that you can't manipulate this embedded site with JS.

The normal site view works because it is associated with tabs. Unfortunately, nothing displayed in the sidebar is tied to tabs, and Bugzilla considers "tab" to be the most complicated and difficult part of Mozilla's source code. Giving up is wise.

@PressJump
Copy link
Member Author

Hi, @PressJump

Floorp has same problem. but, I could understand the cause.

Well, many addons need "tab" permission. However, it turns out that this doesn't work for normal browser elements or panels inside sidebars.

The solution is to embed "chrome://browser/content/browser.xhtml" but unfortunately it's almost certain that you can't manipulate this embedded site with JS.

The normal site view works because it is associated with tabs. Unfortunately, nothing displayed in the sidebar is tied to tabs, and Bugzilla considers "tab" to be the most complicated and difficult part of Mozilla's source code. Giving up is wise.

I see. I understand that routing the js of ublock would also be a problem. I will keep the issue open for any future changes but this is a large roadblock. Thank you for your help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants