Skip to content

Suppress insecure request warnings when setting skip_tls to True #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bobbins228 opened this issue Aug 22, 2023 · 0 comments · Fixed by #320
Closed

Suppress insecure request warnings when setting skip_tls to True #319

Bobbins228 opened this issue Aug 22, 2023 · 0 comments · Fixed by #320
Assignees

Comments

@Bobbins228
Copy link
Contributor

Bobbins228 commented Aug 22, 2023

WHY

Why is this change being made?
Currently when someone logs in with skip_tls=True you will receive a warning like this

warnings.warn(
/opt/app-root/lib64/python3.8/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host <HOST>. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings

This is fine you should be warned at least once but every other action such as cluster.up() will produce this warning.
Running cluster.wait_ready() will result in your console output being flooded with this warning while waiting for the cluster to be ready.

WHAT

What is being asked for?
We should only allow this warning to show upon logging in.

HOW

Suggestions for how this may be solved. [Optional]
We can pass urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) just before the successful login message

TESTS

List of related tests

DONE

Bullet point items for what should be completed

@Bobbins228 Bobbins228 changed the title Suppress insecure request warnings when setting skip_tls_verify to True Suppress insecure request warnings when setting skip_tls to True Aug 22, 2023
@Bobbins228 Bobbins228 self-assigned this Aug 22, 2023
@Bobbins228 Bobbins228 moved this from In Progress to Ready For Review in Project CodeFlare Sprint Board Aug 22, 2023
@KPostOffice KPostOffice moved this from Ready For Review to In Review in Project CodeFlare Sprint Board Aug 22, 2023
@Bobbins228 Bobbins228 moved this from In Review to Ready For Review in Project CodeFlare Sprint Board Aug 23, 2023
@Bobbins228 Bobbins228 moved this from Ready For Review to In Review in Project CodeFlare Sprint Board Aug 29, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Project CodeFlare Sprint Board Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant