Skip to content

Plugin throws Cannot read property 'prepare' of undefined when recompiling #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ValiDraganescu opened this issue Jul 14, 2019 · 3 comments · Fixed by #163
Closed

Plugin throws Cannot read property 'prepare' of undefined when recompiling #162

ValiDraganescu opened this issue Jul 14, 2019 · 3 comments · Fixed by #163
Assignees
@JackCuthbert
Labels
bug released

Comments

@ValiDraganescu
Copy link

Plugin throws Cannot read property 'prepare' of undefined when recompiling

This happens in version 1.1.8 after updating some code and te watcher kicks in to recompile.
@JackCuthbert
Copy link
Contributor

This is my bad, oops. Have repro'd this, will sort this asap!

@JackCuthbert JackCuthbert self-assigned this Jul 14, 2019
JackCuthbert added a commit that referenced this issue Jul 15, 2019
@JackCuthbert
fix: watch files callback missing correct this context
ea9d96c 
After the refactor, I broke this by removing the bind in the hooks.
Adding the bind to the callback function retains the this context while
keeping the modularity of the hooks property.

Fixes #162
@JackCuthbert JackCuthbert mentioned this issue Jul 15, 2019
Merged
@divyenduz
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ValiDraganescu
Copy link
Author

You have been fast, 10x!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackCuthbert JackCuthbert

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: watch files callback missing correct this context serverless/serverless-plugin-typescript
3 participants
@divyenduz @JackCuthbert @ValiDraganescu