Skip to content

Don't show useless ColorBar and Transform folds #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolaskruchten opened this issue Aug 15, 2018 · 3 comments · Fixed by #699
Closed

Don't show useless ColorBar and Transform folds #695

nicolaskruchten opened this issue Aug 15, 2018 · 3 comments · Fixed by #699
Assignees

Comments

@nicolaskruchten
Copy link
Contributor

Now that we don't let users see the Color Bar or Transform panels at all if they're 100% useless we can go one final step further and just not render the folds for the traces where nothing is possible, so users should never ever see "no color bar for this trace" or "no transforms possible here" or whatever.

@dmt0
Copy link
Contributor

dmt0 commented Aug 16, 2018

Are those really useless? Our support for transforms for example is quite arbitrary right now. It's missing on a lot of trace types where it could theoretically be implemented. I think we should rather have a more descriptive message on those folds. For transforms it could be a list of trace types that are supported. For Colorbar - well nobody specifically needs a colorbar, so maybe we can kill that one.

@nicolaskruchten
Copy link
Contributor Author

Well if I have a scatter trace and a pie trace, and I go to transforms, it's pretty useless for me to see a pie-trace fold that says "I'm useless" :)

@dmt0
Copy link
Contributor

dmt0 commented Aug 16, 2018

But if I have a 3d trace with no 2d array data, that has no reason not to have transforms?

I'd do this after #656 resolves.

@dmt0 dmt0 mentioned this issue Aug 16, 2018
@dmt0 dmt0 closed this as completed in #699 Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants