From 6f3c3c0694fbeb247a5ec843cd6a9400e5025eb2 Mon Sep 17 00:00:00 2001 From: M-NK-Y Date: Sat, 21 Jan 2023 14:48:45 +1100 Subject: [PATCH 1/2] Changes to `show` method for Windows --- plotly/src/plot.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/plotly/src/plot.rs b/plotly/src/plot.rs index bcfa7f45..ac80af65 100644 --- a/plotly/src/plot.rs +++ b/plotly/src/plot.rs @@ -471,9 +471,8 @@ impl Plot { fn show_with_default_app(temp_path: &str) { use std::process::Command; Command::new("cmd") - .arg("/C") - .arg(format!("start {}", temp_path)) - .output() + .args(&["/C", "start", &format!(r#"{}"#, temp_path)]) + .spawn() .expect(DEFAULT_HTML_APP_NOT_FOUND); } } From 0ba83831593d0a963b80c85abe53e16b7f89e929 Mon Sep 17 00:00:00 2001 From: M-NK-Y Date: Thu, 16 Feb 2023 11:46:16 +1100 Subject: [PATCH 2/2] `CHANGELOG.md` PR credits updated --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b5e17b43..d5cc7b86 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a ## [0.8.4] - 2023-01-xx ### Fixed -- [[#129](https://github.com/igiagkiozis/plotly/pull/129)] Fix issue for plots not showing in browser in Windows. Thanks to [@juanespj](https://github.com/juanespj) for the PR. +- [[#129](https://github.com/igiagkiozis/plotly/pull/129)] Fix issue for plots not showing in browser in Windows. Thanks to [@juanespj](https://github.com/juanespj) and [@M-NK-Y](https://github.com/M-NK-Y) for the PRs. ## [0.8.3] - 2022-11-04 ### Fixed