Allow shared_yaxes to work with secondary axes
#5180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 12, 2025 21:12
|
This is the output of the test adjusted in the PR, with
|
|
This is my first PR to this repo, I've done my best but please let me know if there's anything I've forgotten or that could be done better. In particular I'm not sure if/how I should add to the CHANGELOG file. |
gmjw
commented
May 12, 2025
| [{"secondary_y": True}, {"secondary_y": True}], | ||
| ], | ||
| ) | ||
| for shared_y_axes in [False, True]: |
There was a problem hiding this comment.
Ideally I would have passed in these options using mark.parametrize, but I don't think that is possible with unittest TestCase methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
shared_yaxesparameter to make_subplots did not previously work on secondary y-axes. It had no effect.This PR fixes this, without affecting how the parameter is applied to normal plots (without secondary y-axes). I have added a simple test to show how the new code "matches" secondary y-axes. The sharing for secondary y-axes is applied right-to-left, in the same way that the sharing for primary y-axes is applied left-to-right (I believe this results in the clearest separation of tick marks when viewing the final plot).
I believe this is a bugfix/improvement. I'm not sure if it's a new feature worthy of any documentation.
I will add some images showing a before/after comparison in comments.