From 52b5051bfbf94f913ed825a8a0923ba9415f1ad7 Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 19 Nov 2020 14:56:57 -0500 Subject: [PATCH 1/2] address issue 5289 - set false locale --- src/plots/plots.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plots/plots.js b/src/plots/plots.js index 2ac82672cee..bccb37b4130 100644 --- a/src/plots/plots.js +++ b/src/plots/plots.js @@ -667,7 +667,7 @@ function emptySubplotLists() { */ function getFormatObj(gd, formatKeys) { var locale = gd._context.locale; - if(!locale) locale === 'en-US'; + if(!locale) locale = 'en-US'; var formatDone = false; var formatObj = {}; From 0a21710222a4025b8223ecbacd630b3262035d3a Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 19 Nov 2020 14:57:37 -0500 Subject: [PATCH 2/2] address issue 5289 - use if block instead of loop --- src/traces/histogram/cross_trace_defaults.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/traces/histogram/cross_trace_defaults.js b/src/traces/histogram/cross_trace_defaults.js index 906bac67a8c..5a9edd34cdf 100644 --- a/src/traces/histogram/cross_trace_defaults.js +++ b/src/traces/histogram/cross_trace_defaults.js @@ -174,10 +174,9 @@ module.exports = function crossTraceDefaults(fullData, fullLayout) { } var binGroupFound = false; - for(i = 0; i < traces.length; i++) { - traceOut = traces[i]; + if(traces.length) { + traceOut = traces[0]; binGroupFound = coerce('bingroup'); - break; } groupName = binGroupFound || groupName;