Skip to content

Additional animation issues #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 5 tasks
rreusser opened this issue Sep 13, 2016 · 4 comments
Closed
2 of 5 tasks

Additional animation issues #933

rreusser opened this issue Sep 13, 2016 · 4 comments
Labels
bug something broken feature something new

Comments

@rreusser
Copy link
Contributor

rreusser commented Sep 13, 2016

I've found some additional issues related to animation that should be fixed ASAP:

  • transforms are an array, which extendDeepNoArrays accidentally avoids extending
  • animate doesn't obey the correct semantics where changes are applied to all traces when trace indices not specified (copy from generalized function as a result of Plotly.update?)
  • animate should be able to apply more than one nextFrame per frame in order to keep up with changes
  • animation should emit an event on each frame so that you can figure out which frame it's on! This is crucial for displaying information about an ongoing animation.
  • convert async sequences to Lib.syncOrAsync (see first try in Move plotly.animate to Lib.syncOrAsync #1693)
@rreusser rreusser self-assigned this Sep 13, 2016
@etpinard etpinard added bug something broken feature something new labels Sep 13, 2016
@rreusser
Copy link
Contributor Author

rreusser commented Sep 16, 2016

@etpinard @monfera Curious to hear your thoughts on the frame merging issue.

Animations currently 1) expand objects (e.g. 'marker.color' -> {marker: {color: ...}}), then uses extendDeepNoArrays to perform the actual merging into the current state. That generally simplifies the definition of frames and is mostly okay except for a couple issues:

  • Transforms don't get properly merged because of the NoArrays part
  • {'marker.color': ...} and marker: {color: ...} both have the same effect, which makes frames nice and easy to write, but is slightly different than the rest of plotly which overwrites all marker properties for the second case.
  • animations don't do array indexing like {'transforms.0.type': ...}

Long story short, I need to fix a couple bugs, so I either need to commit to the current approach and make it 100% correct, or I need to reevaluate and make the right choice about the most straightforward and sensible way for this to work.

@rreusser
Copy link
Contributor Author

After a brief discussion, the conclusion is that the current behavior is best: attribute strings are good for single properties but awkward for whole frames (which would then need every property attribute-stringed, which wouldn't really be acceptable).

Then working through transform array logic…

@etpinard
Copy link
Contributor

etpinard commented Sep 21, 2016

After #956 it would be easy

  • add animation for scatter trace with 'text' mode.

@gvwilson
Copy link
Contributor

gvwilson commented Jun 5, 2024

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

@gvwilson gvwilson closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken feature something new
Projects
None yet
Development

No branches or pull requests

3 participants