Skip to content

Commit debd59b

Browse files
author
Victor Bezak
committed
added comments for readability
1 parent b68537e commit debd59b

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

src/plots/cartesian/axes.js

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -661,28 +661,29 @@ axes.prepTicks = function(ax, opts) {
661661
if(ax.tickmode === 'sync') {
662662
var baseAxis = ax._mainAxis;
663663

664+
// get range min and max to find range delta of axis 1
664665
var minValBaseAxis = Math.min(baseAxis.range[0], baseAxis.range[1]);
665666
var maxValBaseAxis = Math.max(baseAxis.range[0], baseAxis.range[1]);
666-
667667
var rangeDeltaBaseAxis = Math.abs(maxValBaseAxis - minValBaseAxis);
668668

669-
var dtickRatio = rangeDeltaBaseAxis / baseAxis.dtick;
670-
669+
// get range min and max to find range delta of axis 2
671670
var minValAxis = Math.min(ax.range[0], ax.range[1]);
672671
var maxValAxis = Math.max(ax.range[0], ax.range[1]);
672+
var rangeDeltaCurrentAxis = Math.abs(maxValAxis - minValAxis);
673673

674-
var rangeDeltaAxis = Math.abs(maxValAxis - minValAxis);
675-
676-
ax.dtick = rangeDeltaAxis / dtickRatio;
674+
// set second axis' dtick value to be based off of same ratio as the first axis
675+
var dtickRatio = rangeDeltaBaseAxis / baseAxis.dtick;
676+
ax.dtick = rangeDeltaCurrentAxis / dtickRatio;
677677

678+
// validate that the axis has values before we try to use them for tick0 calculation
678679
if(baseAxis && baseAxis._vals.length > 0) {
680+
// get position of first axis' starting tick
679681
var firstTickPosition = baseAxis.l2p(baseAxis._vals[0].x);
680-
681682
var firstTickPercentage = firstTickPosition / baseAxis._length;
682683

683-
var offsetVal = rangeDeltaAxis * (1 - firstTickPercentage);
684-
685-
ax.tick0 = offsetVal + minValAxis;
684+
// set current axis to have same starting tick position
685+
var currentAxisOffsetVal = rangeDeltaCurrentAxis * (1 - firstTickPercentage);
686+
ax.tick0 = currentAxisOffsetVal + minValAxis;
686687
}
687688
} else if(ax.tickmode === 'auto' || !ax.dtick) { // calculate max number of (auto) ticks to display based on plot size
688689
var nt = ax.nticks;

0 commit comments

Comments
 (0)