Skip to content

Commit de644e6

Browse files
committed
use (now stock) jasmine failFast option
1 parent be3da83 commit de644e6

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

package-lock.json

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@
137137
"karma": "^4.1.0",
138138
"karma-browserify": "^6.0.0",
139139
"karma-chrome-launcher": "^2.0.0",
140-
"karma-fail-fast-reporter": "^1.0.5",
141140
"karma-firefox-launcher": "^1.0.1",
142141
"karma-ie-launcher": "^1.0.0",
143142
"karma-jasmine": "^2.0.1",

test/jasmine/karma.conf.js

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ var pathToUnpolyfill = path.join(__dirname, 'assets', 'unpolyfill.js');
120120
var pathToMathJax = path.join(constants.pathToDist, 'extras', 'mathjax');
121121

122122
var reporters = ((isFullSuite && !argv.tags) || argv.showSkipped) ? ['dots', 'spec'] : ['progress'];
123-
if(argv.failFast) reporters.push('fail-fast');
124123
if(argv.verbose) reporters.push('verbose');
125124

126125
function func(config) {
@@ -255,7 +254,8 @@ func.defaultConfig = {
255254

256255
// See https://jasmine.github.io/api/3.4/Configuration.html
257256
jasmine: {
258-
random: argv.randomize
257+
random: argv.randomize,
258+
failFast: argv.failFast
259259
}
260260
},
261261

@@ -265,15 +265,8 @@ func.defaultConfig = {
265265
suppressFailed: true,
266266
suppressPassed: true,
267267
suppressSkipped: false,
268-
showSpecTiming: false,
269-
// use 'karma-fail-fast-reporter' to fail fast w/o conflicting
270-
// with other karma plugins
271-
failFast: false
272-
},
273-
274-
// TODO !!!
275-
// e.g. when a test file does not container a given spec tags
276-
failOnEmptyTestSuite: false
268+
showSpecTiming: false
269+
}
277270
};
278271

279272
func.defaultConfig.preprocessors[pathToCustomMatchers] = ['browserify'];

0 commit comments

Comments
 (0)