fixes and test for checklist in #2508

Author: alexcjohnson

src/plot_api/plot_api.js

@@ -2467,13 +2467,6 @@ function getDiffFlags(oldContainer, newContainer, outerparts, opts) {
         return valObject.valType === 'data_array' || valObject.arrayOk;
     }
 
-    // for transforms: look at _fullInput rather than the transform result, which often
-    // contains generated arrays.
-    var newFullInput = newContainer._fullInput;
-    var oldFullInput = oldContainer._fullInput;
-    if(newFullInput && newFullInput !== newContainer) newContainer = newFullInput;
-    if(oldFullInput && oldFullInput !== oldContainer) oldContainer = oldFullInput;
-
     for(key in oldContainer) {
         // short-circuit based on previous calls or previous keys that already maximized the pathway
         if(flags.calc) return;

src/plot_api/plot_schema.js

@@ -266,6 +266,9 @@ exports.getTraceValObject = function(trace, parts) {
     var moduleAttrs, valObject;
 
     if(head === 'transforms') {
+        if(parts.length === 1) {
+            return baseAttributes.transforms;
+        }
         var transforms = trace.transforms;
         if(!Array.isArray(transforms) || !transforms.length) return false;
         var tNum = parts[1];

src/plots/attributes.js

@@ -156,5 +156,13 @@ module.exports = {
             ].join(' ')
         },
         editType: 'calc'
+    },
+    transforms: {
+        _isLinkedToArray: 'transform',
+        editType: 'calc',
+        description: [
+            'An array of operations that manipulate the trace data,',
+            'for example filtering or sorting the data arrays.'
+        ].join(' ')
     }
 };

test/jasmine/tests/transform_groupby_test.js

@@ -182,6 +182,70 @@ describe('groupby', function() {
             .then(done);
         });
 
+        it('Plotly.react should work', function(done) {
+            var data = Lib.extendDeep([], mockData0);
+            data[0].marker = { size: 20 };
+
+            var gd = createGraphDiv();
+            var dims = [4, 3];
+
+            Plotly.plot(gd, data).then(function() {
+                assertStyle(dims,
+                    ['rgb(255, 0, 0)', 'rgb(0, 0, 255)'],
+                    [1, 1]
+                );
+
+                gd.data[0].marker.opacity = 0.4;
+                // contrived test of relinkPrivateKeys
+                // we'll have to do better if we refactor it to opt-in instead of catchall
+                gd._fullData[0].marker._boo = 'here I am';
+                return Plotly.react(gd, gd.data, gd.layout);
+            }).then(function() {
+                assertStyle(dims,
+                    ['rgb(255, 0, 0)', 'rgb(0, 0, 255)'],
+                    [0.4, 0.4]
+                );
+
+                expect(gd._fullData[0].marker.opacity).toEqual(0.4);
+                expect(gd._fullData[1].marker.opacity).toEqual(0.4);
+                expect(gd._fullData[0].marker._boo).toBe('here I am');
+
+                gd.data[0].marker.opacity = 1;
+                return Plotly.react(gd, gd.data, gd.layout);
+            }).then(function() {
+                assertStyle(dims,
+                    ['rgb(255, 0, 0)', 'rgb(0, 0, 255)'],
+                    [1, 1]
+                );
+
+                expect(gd._fullData[0].marker.opacity).toEqual(1);
+                expect(gd._fullData[1].marker.opacity).toEqual(1);
+
+                // edit just affects the first group
+                gd.data[0].transforms[0].styles[0].value.marker.color = 'green';
+                return Plotly.react(gd, gd.data, gd.layout);
+            }).then(function() {
+                assertStyle(dims,
+                    ['rgb(0, 128, 0)', 'rgb(0, 0, 255)'],
+                    [1, 1]
+                );
+
+                expect(gd._fullData[0].marker.opacity).toEqual(1);
+                expect(gd._fullData[1].marker.opacity).toEqual(1);
+
+                // edit just affects the second group
+                gd.data[0].transforms[0].styles[1].value.marker.color = 'red';
+                return Plotly.react(gd, gd.data, gd.layout);
+            }).then(function() {
+                assertStyle(dims,
+                    ['rgb(0, 128, 0)', 'rgb(255, 0, 0)'],
+                    [1, 1]
+                );
+            })
+            .catch(failTest)
+            .then(done);
+        });
+
         it('Plotly.extendTraces should work', function(done) {
             var data = Lib.extendDeep([], mockData0);