turn front/end/global regex's into 1

- and allow only ' ' in middle instead of all space characters

Author: etpinard

src/lib/clean_number.js

@@ -13,21 +13,16 @@ var isNumeric = require('fast-isnumeric');
 
 var BADNUM = require('../constants/numerical').BADNUM;
 
-// precompile these regex's for speed
-var FRONTJUNK = /^['"%,$#\s']+/;
-var ENDJUNK = /['"%,$#\s']+$/;
-var GLOBALJUNK = /[,\s]/g;
+// precompile for speed
+var JUNK = /^['"%,$#\s']+|[, ]|['"%,$#\s']+$/g;
 
 /**
  * cleanNumber: remove common leading and trailing cruft
  * Always returns either a number or BADNUM.
  */
 module.exports = function cleanNumber(v) {
     if(typeof v === 'string') {
-        v = v
-            .replace(FRONTJUNK, '')
-            .replace(ENDJUNK, '')
-            .replace(GLOBALJUNK, '');
+        v = v.replace(JUNK, '');
     }
 
     if(isNumeric(v)) return Number(v);

test/jasmine/tests/lib_test.js

@@ -1536,7 +1536,7 @@ describe('Test lib.js:', function() {
         it('should not accept other objects or cruft in the middle', function() {
             [
                 NaN, Infinity, -Infinity, null, undefined, new Date(), '',
-                ' ', '\t', '2%2', '2$2', {1: 2}, [1], ['1'], {}, []
+                ' ', '\t', '2\t2', '2%2', '2$2', {1: 2}, [1], ['1'], {}, []
             ].forEach(function(v) {
                 expect(Lib.cleanNumber(v)).toBeUndefined(v);
             });