Skip to content

Commit d87013b

Browse files
committed
🔨 Renamed CantHaveMultipleOutputs for less confusion.
1 parent a676f23 commit d87013b

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

dash/dash.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,7 @@ def duplicate_check():
795795
output.component_id,
796796
output.component_property
797797
).replace(' ', '')
798-
raise exceptions.CantHaveMultipleOutputs(msg)
798+
raise exceptions.DuplicateCallbackOutput(msg)
799799

800800
def _validate_callback_output(self, output_value, output):
801801
valid = [str, dict, int, float, type(None), Component]

dash/exceptions.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,11 @@ class CantHaveMultipleOutputs(CallbackException):
5151
pass
5252

5353

54+
# Renamed for less confusion with multi output.
55+
class DuplicateCallbackOutput(CantHaveMultipleOutputs):
56+
pass
57+
58+
5459
class PreventUpdate(CallbackException):
5560
pass
5661

tests/test_integration.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import dash
1313

1414
from dash.dependencies import Input, Output, State
15-
from dash.exceptions import PreventUpdate, CantHaveMultipleOutputs
15+
from dash.exceptions import PreventUpdate, DuplicateCallbackOutput
1616
from .IntegrationTests import IntegrationTests
1717
from .utils import assert_clean_console, invincible, wait_for
1818

@@ -562,7 +562,7 @@ def on_click(n_clicks, n_clicks_timestamp):
562562

563563
return n_clicks, n_clicks_timestamp
564564

565-
# Dummy callback for CantHaveMultipleOutputs
565+
# Dummy callback for DuplicateCallbackOutput test.
566566
@app.callback(Output('output3', 'children'),
567567
[Input('output-btn', 'n_clicks')])
568568
def dummy_callback(n_clicks):
@@ -572,7 +572,7 @@ def dummy_callback(n_clicks):
572572
return 'Output 3: {}'.format(n_clicks)
573573

574574
# Test that a multi output can't be included in a single output
575-
with self.assertRaises(CantHaveMultipleOutputs) as context:
575+
with self.assertRaises(DuplicateCallbackOutput) as context:
576576
@app.callback(Output('output1', 'children'),
577577
[Input('output-btn', 'n_clicks')])
578578
def on_click_duplicate(n_clicks):
@@ -584,7 +584,7 @@ def on_click_duplicate(n_clicks):
584584
self.assertTrue('output1' in context.exception.args[0])
585585

586586
# Test a multi output cannot contain a used single output
587-
with self.assertRaises(CantHaveMultipleOutputs) as context:
587+
with self.assertRaises(DuplicateCallbackOutput) as context:
588588
@app.callback([Output('output3', 'children'),
589589
Output('output4', 'children')],
590590
[Input('output-btn', 'n_clicks')])

0 commit comments

Comments
 (0)