fix regression + new test (#63)

Author: Marc-Andre-Rivet

packages/dash-table/CHANGELOG.md

@@ -83,4 +83,6 @@
 
     Note: This is a stopgag prop, full implementation of sorting overrides will most probably deprecate it.
 
-    Default value is False.
+    Default value is False.
+
+## RC10 - Fix double click regression

packages/dash-table/dash_table/bundle.js

@@ -1,6 +1,6 @@
 {
   "name": "dash-table",
-  "version": "3.0.0rc9",
+  "version": "3.0.0rc10",
   "description": "Dash table",
   "main": "build/index.js",
   "scripts": {

packages/dash-table/dash_table/demo.js

@@ -1,6 +1,6 @@
 {
   "name": "dash-table",
-  "version": "3.0.0rc9",
+  "version": "3.0.0rc10",
   "description": "Dash table",
   "main": "build/index.js",
   "scripts": {

packages/dash-table/dash_table/package.json

@@ -101,18 +101,27 @@ export default class CellFactory {
         const {
             editable,
             is_focused,
+            row_deletable,
+            row_selectable,
             setProps
         } = this.props;
 
         if (!editable) {
             return;
         }
 
+        // visible col indices
+        const columnIndexOffset =
+            (row_deletable ? 1 : 0) +
+            (row_selectable ? 1 : 0);
+
+        const cellLocation: [number, number] = [idx, i + columnIndexOffset];
+
         if (!is_focused) {
             e.preventDefault();
             const newProps = {
-                selected_cell: [[idx, i]],
-                active_cell: [idx, i],
+                selected_cell: [cellLocation],
+                active_cell: cellLocation,
                 is_focused: true
             };
             setProps(newProps);

packages/dash-table/package.json

@@ -28,4 +28,9 @@ describe('dash basic', () => {
             });
         });
     });
+
+    it('can get cell with double click', () => {
+        DashTable.getCell(3, 3).within(() => cy.get('div').dblclick());
+        DashTable.getCell(3, 3).should('have.class', 'focused');
+    });
 });

packages/dash-table/src/dash-table/components/CellFactory.tsx

@@ -62,6 +62,8 @@
             {'id': 12, 'name': 'Timely response?'},
             {'id': 13, 'name': 'Consumer disputed?'}
         ],
+        n_fixed_columns=2,
+        n_fixed_rows=1,
         row_selectable=True,
         row_deletable=True,
         sorting=True,