Skip to content

Commit 53d8fcc

Browse files
authored
Merge pull request #1015 from plotly/946-testing-entrypoint
🔇 remove the warning as it might confuse non dash usage
2 parents 64fefff + 23bda86 commit 53d8fcc

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

dash/testing/plugin.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
# pylint: disable=missing-docstring,redefined-outer-name
2-
import warnings
2+
import pytest
33
from .consts import SELENIUM_GRID_DEFAULT
44

55

66
try:
7-
import pytest
8-
97
from dash.testing.application_runners import (
108
ThreadedRunner,
119
ProcessRunner,
@@ -14,17 +12,15 @@
1412
from dash.testing.browser import Browser
1513
from dash.testing.composite import DashComposite, DashRComposite
1614
except ImportError:
17-
warnings.warn("run `pip install dash[testing]` if you need dash.testing")
18-
19-
WEBDRIVERS = {"Chrome", "Firefox"}
15+
pass
2016

2117

2218
def pytest_addoption(parser):
2319
dash = parser.getgroup("Dash", "Dash Integration Tests")
2420

2521
dash.addoption(
2622
"--webdriver",
27-
choices=tuple(WEBDRIVERS),
23+
choices=("Chrome", "Firefox"),
2824
default="Chrome",
2925
help="Name of the selenium driver to use",
3026
)
@@ -51,8 +47,8 @@ def pytest_addoption(parser):
5147
dash.addoption(
5248
"--percy-assets",
5349
action="store",
54-
default='tests/assets',
55-
help="configure how Percy will discover your app's assets"
50+
default="tests/assets",
51+
help="configure how Percy will discover your app's assets",
5652
)
5753

5854
dash.addoption(

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ def read_req_file(req_type):
2626
long_description=io.open("README.md", encoding="utf-8").read(),
2727
long_description_content_type="text/markdown",
2828
install_requires=read_req_file("install"),
29+
python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*",
2930
extras_require={
3031
"dev": read_req_file("dev"),
3132
"testing": read_req_file("testing"),

0 commit comments

Comments
 (0)