Skip to content

Commit b43dd10

Browse files
arnaud-lbarnaud-lb
committed
Merge branch 'PHP-8.3'
* PHP-8.3: [ci skip] NEWS for GH-15275 [ci skip] NEWS for GH-15275 Fix crash during GC of suspended generator delegate (#15275)
2 parents 2b30b22 + 4606202 commit b43dd10

8 files changed

+313
-6
lines changed

‎Zend/tests/gh15275-001.phpt

+38
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
--TEST--
2+
GH-15275 001: Crash during GC of suspended generator delegate
3+
--FILE--
4+
<?php
5+
6+
class It implements \IteratorAggregate
7+
{
8+
public function getIterator(): \Generator
9+
{
10+
yield 'foo';
11+
Fiber::suspend();
12+
var_dump("not executed");
13+
}
14+
}
15+
16+
function f() {
17+
var_dump(yield from new It());
18+
}
19+
20+
$iterable = f();
21+
22+
$fiber = new Fiber(function () use ($iterable) {
23+
var_dump($iterable->current());
24+
$iterable->next();
25+
var_dump("not executed");
26+
});
27+
28+
$ref = $fiber;
29+
30+
$fiber->start();
31+
32+
gc_collect_cycles();
33+
34+
?>
35+
==DONE==
36+
--EXPECT--
37+
string(3) "foo"
38+
==DONE==

‎Zend/tests/gh15275-002.phpt

+57
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
--TEST--
2+
GH-15275 002: Crash during GC of suspended generator delegate
3+
--FILE--
4+
<?php
5+
6+
class It implements \IteratorAggregate
7+
{
8+
public function getIterator(): \Generator
9+
{
10+
yield 'foo';
11+
try {
12+
Fiber::suspend();
13+
} finally {
14+
var_dump(__METHOD__);
15+
}
16+
var_dump("not executed");
17+
}
18+
}
19+
20+
function f() {
21+
try {
22+
var_dump(new stdClass, yield from new It());
23+
} finally {
24+
var_dump(__FUNCTION__);
25+
}
26+
}
27+
28+
function g() {
29+
try {
30+
var_dump(new stdClass, yield from f());
31+
} finally {
32+
var_dump(__FUNCTION__);
33+
}
34+
}
35+
36+
$gen = g();
37+
38+
$fiber = new Fiber(function () use ($gen) {
39+
var_dump($gen->current());
40+
$gen->next();
41+
var_dump("not executed");
42+
});
43+
44+
$ref = $fiber;
45+
46+
$fiber->start();
47+
48+
gc_collect_cycles();
49+
50+
?>
51+
==DONE==
52+
--EXPECT--
53+
string(3) "foo"
54+
==DONE==
55+
string(15) "It::getIterator"
56+
string(1) "f"
57+
string(1) "g"

‎Zend/tests/gh15275-003.phpt

+51
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
--TEST--
2+
GH-15275 003: Crash during GC of suspended generator delegate
3+
--FILE--
4+
<?php
5+
6+
class It implements \IteratorAggregate
7+
{
8+
public function getIterator(): \Generator
9+
{
10+
yield 'foo';
11+
throw new \Exception();
12+
var_dump("not executed");
13+
}
14+
}
15+
16+
function f() {
17+
try {
18+
var_dump(new stdClass, yield from new It());
19+
} finally {
20+
var_dump(__FUNCTION__);
21+
}
22+
}
23+
24+
function g() {
25+
try {
26+
var_dump(new stdClass, yield from f());
27+
} finally {
28+
var_dump(__FUNCTION__);
29+
}
30+
}
31+
32+
$gen = g();
33+
34+
var_dump($gen->current());
35+
$gen->next();
36+
37+
?>
38+
==DONE==
39+
--EXPECTF--
40+
string(3) "foo"
41+
string(1) "f"
42+
string(1) "g"
43+
44+
Fatal error: Uncaught Exception in %s:8
45+
Stack trace:
46+
#0 %s(15): It->getIterator()
47+
#1 %s(23): f()
48+
#2 [internal function]: g()
49+
#3 %s(32): Generator->next()
50+
#4 {main}
51+
thrown in %s on line 8

‎Zend/tests/gh15275-004.phpt

+44
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
--TEST--
2+
GH-15275 004: Crash during GC of suspended generator delegate
3+
--FILE--
4+
<?php
5+
6+
class It implements \IteratorAggregate
7+
{
8+
public function getIterator(): \Generator
9+
{
10+
yield 'foo';
11+
echo "baz\n";
12+
throw new \Exception();
13+
}
14+
15+
public function __destruct()
16+
{
17+
gc_collect_cycles();
18+
}
19+
}
20+
21+
function f() {
22+
var_dump(new stdClass, yield from new It());
23+
}
24+
25+
$gen = f();
26+
27+
var_dump($gen->current());
28+
$gen->next();
29+
30+
gc_collect_cycles();
31+
32+
?>
33+
==DONE==
34+
--EXPECTF--
35+
string(3) "foo"
36+
baz
37+
38+
Fatal error: Uncaught Exception in %s:9
39+
Stack trace:
40+
#0 %s(19): It->getIterator()
41+
#1 [internal function]: f()
42+
#2 %s(25): Generator->next()
43+
#3 {main}
44+
thrown in %s on line 9

‎Zend/tests/gh15275-005.phpt

+51
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
--TEST--
2+
GH-15275 005: Crash during GC of suspended generator delegate
3+
--FILE--
4+
<?php
5+
6+
class It implements \IteratorAggregate
7+
{
8+
public function getIterator(): \Generator
9+
{
10+
yield 'foo';
11+
throw new \Exception();
12+
var_dump("not executed");
13+
}
14+
}
15+
16+
function f() {
17+
try {
18+
var_dump(new stdClass, yield from new It());
19+
} finally {
20+
var_dump(__FUNCTION__);
21+
}
22+
}
23+
24+
function g() {
25+
try {
26+
var_dump(new stdClass, yield from f());
27+
} finally {
28+
var_dump(__FUNCTION__);
29+
}
30+
}
31+
32+
$gen = g();
33+
34+
var_dump($gen->current());
35+
$gen->next();
36+
37+
?>
38+
==DONE==
39+
--EXPECTF--
40+
string(3) "foo"
41+
string(1) "f"
42+
string(1) "g"
43+
44+
Fatal error: Uncaught Exception in %s:8
45+
Stack trace:
46+
#0 %s(15): It->getIterator()
47+
#1 %s(23): f()
48+
#2 [internal function]: g()
49+
#3 %s(32): Generator->next()
50+
#4 {main}
51+
thrown in %s on line 8

‎Zend/tests/gh15275-006.phpt

+51
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
--TEST--
2+
GH-15275 006: Crash during GC of suspended generator delegate
3+
--FILE--
4+
<?php
5+
6+
class It implements \IteratorAggregate
7+
{
8+
public function getIterator(): \Generator
9+
{
10+
yield 'foo';
11+
echo "baz\n";
12+
throw new \Exception();
13+
}
14+
15+
public function __destruct()
16+
{
17+
throw new \Exception();
18+
}
19+
}
20+
21+
function f() {
22+
var_dump(new stdClass, yield from new It());
23+
}
24+
25+
$gen = f();
26+
27+
var_dump($gen->current());
28+
$gen->next();
29+
30+
gc_collect_cycles();
31+
32+
?>
33+
==DONE==
34+
--EXPECTF--
35+
string(3) "foo"
36+
baz
37+
38+
Fatal error: Uncaught Exception in %s:9
39+
Stack trace:
40+
#0 %s(19): It->getIterator()
41+
#1 [internal function]: f()
42+
#2 %s(25): Generator->next()
43+
#3 {main}
44+
45+
Next Exception in %s:14
46+
Stack trace:
47+
#0 %s(19): It->__destruct()
48+
#1 [internal function]: f()
49+
#2 %s(25): Generator->next()
50+
#3 {main}
51+
thrown in %s on line 14

‎Zend/zend_execute.c

+7-1
Original file line numberDiff line numberDiff line change
@@ -4762,7 +4762,13 @@ ZEND_API HashTable *zend_unfinished_execution_gc_ex(zend_execute_data *execute_d
47624762
}
47634763

47644764
if (call) {
4765-
uint32_t op_num = execute_data->opline - op_array->opcodes;
4765+
uint32_t op_num;
4766+
if (UNEXPECTED(execute_data->opline->opcode == ZEND_HANDLE_EXCEPTION)) {
4767+
op_num = EG(opline_before_exception) - op_array->opcodes;
4768+
} else {
4769+
op_num = execute_data->opline - op_array->opcodes;
4770+
}
4771+
ZEND_ASSERT(op_num < op_array->last);
47664772
if (suspended_by_yield) {
47674773
/* When the execution was suspended by yield, EX(opline) points to
47684774
* next opline to execute. Otherwise, it points to the opline that

‎Zend/zend_generators.c

+14-5
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include "zend_closures.h"
2727
#include "zend_generators_arginfo.h"
2828
#include "zend_observer.h"
29+
#include "zend_vm_opcodes.h"
2930

3031
ZEND_API zend_class_entry *zend_ce_generator;
3132
ZEND_API zend_class_entry *zend_ce_ClosedGeneratorException;
@@ -516,6 +517,8 @@ static void zend_generator_throw_exception(zend_generator *generator, zval *exce
516517
* to pretend the exception happened during the YIELD opcode. */
517518
EG(current_execute_data) = generator->execute_data;
518519
generator->execute_data->opline--;
520+
ZEND_ASSERT(generator->execute_data->opline->opcode == ZEND_YIELD
521+
|| generator->execute_data->opline->opcode == ZEND_YIELD_FROM);
519522
generator->execute_data->prev_execute_data = original_execute_data;
520523

521524
if (exception) {
@@ -524,13 +527,14 @@ static void zend_generator_throw_exception(zend_generator *generator, zval *exce
524527
zend_rethrow_exception(EG(current_execute_data));
525528
}
526529

530+
generator->execute_data->opline++;
531+
527532
/* if we don't stop an array/iterator yield from, the exception will only reach the generator after the values were all iterated over */
528533
if (UNEXPECTED(Z_TYPE(generator->values) != IS_UNDEF)) {
529534
zval_ptr_dtor(&generator->values);
530535
ZVAL_UNDEF(&generator->values);
531536
}
532537

533-
generator->execute_data->opline++;
534538
EG(current_execute_data) = original_execute_data;
535539
}
536540

@@ -660,8 +664,6 @@ ZEND_API zend_generator *zend_generator_update_current(zend_generator *generator
660664

661665
static zend_result zend_generator_get_next_delegated_value(zend_generator *generator) /* {{{ */
662666
{
663-
--generator->execute_data->opline;
664-
665667
zval *value;
666668
if (Z_TYPE(generator->values) == IS_ARRAY) {
667669
HashTable *ht = Z_ARR(generator->values);
@@ -743,14 +745,12 @@ static zend_result zend_generator_get_next_delegated_value(zend_generator *gener
743745
}
744746
}
745747

746-
++generator->execute_data->opline;
747748
return SUCCESS;
748749

749750
failure:
750751
zval_ptr_dtor(&generator->values);
751752
ZVAL_UNDEF(&generator->values);
752753

753-
++generator->execute_data->opline;
754754
return FAILURE;
755755
}
756756
/* }}} */
@@ -815,6 +815,15 @@ ZEND_API void zend_generator_resume(zend_generator *orig_generator) /* {{{ */
815815
generator->flags &= ~ZEND_GENERATOR_IN_FIBER;
816816
return;
817817
}
818+
if (UNEXPECTED(EG(exception))) {
819+
/* Decrementing opline_before_exception to pretend the exception
820+
* happened during the YIELD_FROM opcode. */
821+
if (generator->execute_data) {
822+
ZEND_ASSERT(generator->execute_data->opline == EG(exception_op));
823+
ZEND_ASSERT((EG(opline_before_exception)-1)->opcode == ZEND_YIELD_FROM);
824+
EG(opline_before_exception)--;
825+
}
826+
}
818827
/* If there are no more delegated values, resume the generator
819828
* after the "yield from" expression. */
820829
}

0 commit comments

Comments
 (0)