Skip to content

Commit 9c537de

Browse files
authored
Fix some -Wimplicit-function-declaration errors on Windows (GH-15325)
While clang is picky about these, MSVC doesn't seem to care and would only report the calls to undeclared functions as errors during link time. Still, obviously, MSVC is fine with having the declarations during compile time.
1 parent c02c1d4 commit 9c537de

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

ext/standard/proc_open.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@
2323
#include "SAPI.h"
2424
#include "main/php_network.h"
2525
#include "zend_smart_str.h"
26+
#ifdef PHP_WIN32
27+
# include "win32/sockets.h"
28+
#endif
2629

2730
#ifdef HAVE_SYS_WAIT_H
2831
#include <sys/wait.h>

sapi/cli/php_cli_server.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
#ifdef PHP_WIN32
2525
# include <process.h>
2626
# include <io.h>
27+
# include "win32/console.h"
2728
# include "win32/time.h"
2829
# include "win32/signal.h"
2930
# include "win32/php_registry.h"

0 commit comments

Comments
 (0)