Skip to content

Commit 7e1a241

Browse files
authored
Reduce excessive stack reserve for testing in CI (GH-17166)
For some reason the stack reserve of php.exe and php-cgi.exe is very large on Windows (64MB)[1]. While this might not be bad for production purposes, it causes stack_limit_014.phpt to be unbearably slow; the test may easily run for a minute, and due to a recent `stream_select()` improvement[2], that can cause a timeout, what triggers the test to be run again. So this single test case may run for two minutes, and still might fail (happened a couple of times). Instead of skipping the test in CI, we reduce the stack reserve to 8MB, what improves the performance of this test case (and maybe others), and should still be good enough for CI. [1] <54906c7> [2] <b614b4a>
1 parent e02c226 commit 7e1a241

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/scripts/windows/test_task.bat

+4
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,10 @@ for %%i in (ldap) do (
131131
del %PHP_BUILD_DIR%\php_%%i.dll
132132
)
133133

134+
rem reduce excessive stack reserve for testing
135+
editbin /stack:8388608 %PHP_BUILD_DIR%\php.exe
136+
editbin /stack:8388608 %PHP_BUILD_DIR%\php-cgi.exe
137+
134138
set TEST_PHPDBG_EXECUTABLE=%PHP_BUILD_DIR%\phpdbg.exe
135139

136140
if "%ASAN%" equ "1" set ASAN_OPTS=--asan

0 commit comments

Comments
 (0)