Skip to content

Commit 68185ba

Browse files
committed
opcache: Patch SSE based fast_memcpy() implementation
Use _mm_store_si128() instead of _mm_stream_si128(). This ensures that copied memory is preserved in data cache, which is good as the interpretor will start to use this data without the need to go back to memory. _mm_stream* is intended to be used for stores where we want to avoid reading data into the cache and the cache pollution; in our scenario it seems that preserving the data in cache has a positive impact. Tests on WordPress 4.1 show ~1% performance increase with fast_memcpy() in place versus standard memcpy() when running php-cgi -T10000 wordpress/index.php. I also updated SW prefetching on target memory but its contribution is almost negligible. The address to be prefetched will be used in a couple of cycles (at the next iteration) while the data from memory will be available in >100 cycles.
1 parent 4e66cce commit 68185ba

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

ext/opcache/zend_accelerator_util_funcs.c

+5-4
Original file line numberDiff line numberDiff line change
@@ -658,16 +658,17 @@ static zend_always_inline void fast_memcpy(void *dest, const void *src, size_t s
658658

659659
do {
660660
_mm_prefetch(dqsrc + 4, _MM_HINT_NTA);
661+
_mm_prefetch(dqdest + 4, _MM_HINT_T0);
661662

662663
__m128i xmm0 = _mm_load_si128(dqsrc + 0);
663664
__m128i xmm1 = _mm_load_si128(dqsrc + 1);
664665
__m128i xmm2 = _mm_load_si128(dqsrc + 2);
665666
__m128i xmm3 = _mm_load_si128(dqsrc + 3);
666667
dqsrc += 4;
667-
_mm_stream_si128(dqdest + 0, xmm0);
668-
_mm_stream_si128(dqdest + 1, xmm1);
669-
_mm_stream_si128(dqdest + 2, xmm2);
670-
_mm_stream_si128(dqdest + 3, xmm3);
668+
_mm_store_si128(dqdest + 0, xmm0);
669+
_mm_store_si128(dqdest + 1, xmm1);
670+
_mm_store_si128(dqdest + 2, xmm2);
671+
_mm_store_si128(dqdest + 3, xmm3);
671672
dqdest += 4;
672673
} while (dqsrc != end);
673674
}

0 commit comments

Comments
 (0)