Skip to content

Commit 060a409

Browse files
committed
Revert unnecessary changes
1 parent a48f879 commit 060a409

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

Zend/zend_compile.h

-3
Original file line numberDiff line numberDiff line change
@@ -465,9 +465,6 @@ typedef struct _zend_property_info {
465465
#define OBJ_PROP_TO_NUM(offset) \
466466
(((offset) - OBJ_PROP_TO_OFFSET(0)) / sizeof(zval))
467467

468-
#define Z_PROP_TABLE_OFFSET(prop_info) \
469-
OBJ_PROP_TO_NUM(!((prop_info)->prototype->flags & ZEND_ACC_VIRTUAL) ? (prop_info)->prototype->offset : (prop_info)->offset)
470-
471468
typedef struct _zend_class_constant {
472469
zval value; /* flags are stored in u2 */
473470
zend_string *doc_comment;

Zend/zend_inheritance.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -1684,7 +1684,8 @@ void zend_build_properties_info_table(zend_class_entry *ce)
16841684
ZEND_HASH_MAP_FOREACH_PTR(&ce->properties_info, prop) {
16851685
if (prop->ce == ce && (prop->flags & ZEND_ACC_STATIC) == 0
16861686
&& !(prop->flags & ZEND_ACC_VIRTUAL)) {
1687-
table[Z_PROP_TABLE_OFFSET(prop)] = prop;
1687+
uint32_t prop_table_offset = OBJ_PROP_TO_NUM(!(prop->prototype->flags & ZEND_ACC_VIRTUAL) ? prop->prototype->offset : prop->offset);
1688+
table[prop_table_offset] = prop;
16881689
}
16891690
} ZEND_HASH_FOREACH_END();
16901691
}

ext/opcache/jit/zend_jit_ir.c

+8-4
Original file line numberDiff line numberDiff line change
@@ -14376,7 +14376,8 @@ static int zend_jit_fetch_obj(zend_jit_ctx *jit,
1437614376
if (ce && ce->ce_flags & ZEND_ACC_IMMUTABLE) {
1437714377
ref = ir_CONST_ADDR(prop_info);
1437814378
} else {
14379-
int prop_info_offset = Z_PROP_TABLE_OFFSET(prop_info) * sizeof(void*);
14379+
int prop_info_offset =
14380+
(((prop_info->offset - (sizeof(zend_object) - sizeof(zval))) / sizeof(zval)) * sizeof(void*));
1438014381

1438114382
ref = ir_LOAD_A(ir_ADD_OFFSET(obj_ref, offsetof(zend_object, ce)));
1438214383
ref = ir_LOAD_A(ir_ADD_OFFSET(ref, offsetof(zend_class_entry, properties_info_table)));
@@ -14776,7 +14777,8 @@ static int zend_jit_assign_obj(zend_jit_ctx *jit,
1477614777
if (ce && ce->ce_flags & ZEND_ACC_IMMUTABLE) {
1477714778
ref = ir_CONST_ADDR(prop_info);
1477814779
} else {
14779-
int prop_info_offset = Z_PROP_TABLE_OFFSET(prop_info) * sizeof(void*);
14780+
int prop_info_offset =
14781+
(((prop_info->offset - (sizeof(zend_object) - sizeof(zval))) / sizeof(zval)) * sizeof(void*));
1478014782

1478114783
ref = ir_LOAD_A(ir_ADD_OFFSET(obj_ref, offsetof(zend_object, ce)));
1478214784
ref = ir_LOAD_A(ir_ADD_OFFSET(ref, offsetof(zend_class_entry, properties_info_table)));
@@ -15131,7 +15133,8 @@ static int zend_jit_assign_obj_op(zend_jit_ctx *jit,
1513115133
if (ce && ce->ce_flags & ZEND_ACC_IMMUTABLE) {
1513215134
ref = ir_CONST_ADDR(prop_info);
1513315135
} else {
15134-
int prop_info_offset = Z_PROP_TABLE_OFFSET(prop_info) * sizeof(void*);
15136+
int prop_info_offset =
15137+
(((prop_info->offset - (sizeof(zend_object) - sizeof(zval))) / sizeof(zval)) * sizeof(void*));
1513515138

1513615139
ref = ir_LOAD_A(ir_ADD_OFFSET(obj_ref, offsetof(zend_object, ce)));
1513715140
ref = ir_LOAD_A(ir_ADD_OFFSET(ref, offsetof(zend_class_entry, properties_info_table)));
@@ -15520,7 +15523,8 @@ static int zend_jit_incdec_obj(zend_jit_ctx *jit,
1552015523
if (ce && ce->ce_flags & ZEND_ACC_IMMUTABLE) {
1552115524
ref = ir_CONST_ADDR(prop_info);
1552215525
} else {
15523-
int prop_info_offset = Z_PROP_TABLE_OFFSET(prop_info) * sizeof(void*);
15526+
int prop_info_offset =
15527+
(((prop_info->offset - (sizeof(zend_object) - sizeof(zval))) / sizeof(zval)) * sizeof(void*));
1552415528

1552515529
ref = ir_LOAD_A(ir_ADD_OFFSET(obj_ref, offsetof(zend_object, ce)));
1552615530
ref = ir_LOAD_A(ir_ADD_OFFSET(ref, offsetof(zend_class_entry, properties_info_table)));

0 commit comments

Comments
 (0)