BUG:fix replacer's dtype is not respected (pandas-dev#26632)

peterpanmj · peterpanmj · commit 54b05d8f691f · 2019-10-16T17:49:47.000+08:00
diff --git a/pandas/core/internals/blocks.py b/pandas/core/internals/blocks.py
@@ -2914,6 +2914,8 @@ def _replace_coerce(
             if convert:
                 block = [b.convert(numeric=False, copy=True) for b in block]
             return block
+        if convert:
+            return [self.convert(numeric=False, copy=True)]
         return self
 
 
diff --git a/pandas/core/internals/managers.py b/pandas/core/internals/managers.py
@@ -632,7 +632,7 @@ def comp(s, regex=False):
                         convert=convert,
                         regex=regex,
                     )
-                    if m.any():
+                    if m.any() or convert:
                         new_rb = _extend_blocks(result, new_rb)
                     else:
                         new_rb.append(b)

Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,7 @@ def comp(s, regex=False):`
`632`	`632`	`convert=convert,`
`633`	`633`	`regex=regex,`
`634`	`634`	`)`
`635`		`- if m.any():`
	`635`	`+ if m.any() or convert:`
`636`	`636`	`new_rb = _extend_blocks(result, new_rb)`
`637`	`637`	`else:`
`638`	`638`	`new_rb.append(b)`