Skip to content

pandas.io.tests.test_google:TestGoogle.test_get_data hangs during local testing #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpcloud opened this issue Jun 15, 2013 · 12 comments
Closed
Labels
Build Library building on various platforms
Milestone

Comments

@cpcloud
Copy link
Member

cpcloud commented Jun 15, 2013

No description provided.

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

is there any way to make this faster, it eventually completes but it's taking about 40 ish seconds

@jreback
Copy link
Contributor

jreback commented Jun 18, 2013

this related to #3893?

@jtratner
Copy link
Contributor

Two ideas:

  1. Force all test cases to use a smaller number of attempts (so they don't pause in between).
  2. Change the with_connectivity_check decorator to do the URL check first and skip if it can't connect (so you'd use that as a decorator to the class, as opposed to on a particular method). Could also do that as a global that causes the entire suite to skip if it can't connect.

@jtratner
Copy link
Contributor

@cpcloud We need to merge #3914 to resolve this. I'm going to try slapping a check_before_test to it. (though if you're testing on your computer, you probably have internet access at the time, right?)

@cpcloud
Copy link
Member Author

cpcloud commented Jun 20, 2013

yep i almost always have a connection, but unless i'm explicitly testing something that uses the web i usually run tests with nosetests -A 'not network and not slow' --with-progressive and then remove the slow if that succeeds

@jtratner
Copy link
Contributor

btw - this has now been split into test_multi1 and test_multi2

@cpcloud
Copy link
Member Author

cpcloud commented Jun 22, 2013

it's actually test_google that is slow and should be marked as such

@jreback
Copy link
Contributor

jreback commented Jun 23, 2013

are we doing anything about this one? or moving to 0.12?

@cpcloud
Copy link
Member Author

cpcloud commented Jun 23, 2013

i think should probably close as wontfix...might be nothing to do about it @jreback what do u think?

@cpcloud
Copy link
Member Author

cpcloud commented Jun 23, 2013

i'll be going out so if you're in favor then can u close? thx

@jreback
Copy link
Contributor

jreback commented Jun 23, 2013

I'll move to 12 just in case

@cpcloud
Copy link
Member Author

cpcloud commented Jul 3, 2013

closed in favor of the fact that it's been dealt with in the ongoing clean up of data.py

@cpcloud cpcloud closed this as completed Jul 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

No branches or pull requests

3 participants