Skip to content

pytest on test_html.py failing #30168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JvPy opened this issue Dec 9, 2019 · 6 comments
Closed

pytest on test_html.py failing #30168

JvPy opened this issue Dec 9, 2019 · 6 comments
Labels
Duplicate Report Duplicate issue or pull request

Comments

@JvPy
Copy link
Contributor

JvPy commented Dec 9, 2019 •
edited
Loading

When running pytest -v pandas/tests/io/test_html.py the following test fails:

pandas/tests/io/test_html.py::TestReadHtml::test_thousands_macau_index_col[bs4] FAILED [ 26%]

When I push the file, it passes all verifications on the pipeline.
@TomAugspurger
Copy link
Contributor

What does it fail with? An ImportError?

Most likely needs an importorskip on html5lib and / or beautiful soup.

@JvPy
Copy link
Contributor Author

JvPy commented Dec 9, 2019

Ill check for that! Thanks!

@JvPy
Copy link
Contributor Author

JvPy commented Dec 10, 2019

The test fails here:

pandas/tests/io/test_html.py:389: dfs = self.read_html(macau_data, index_col=0, header=0)

AttributeError: 'NoneType' object has no attribute 'items' on formatter.py, line62.

Can you help me fix this issue?

@ShaharNaveh
Copy link
Member

Same here, But the failing tests passed once I installed an older version of beautifulsoup4, for example 4.7.1.

@jbrockmendel jbrockmendel added the Unreliable Test Unit tests that occasionally fail label Dec 11, 2019
@JvPy
Copy link
Contributor Author

JvPy commented Dec 12, 2019

downgrading beautifulsoup4 worked for me as well

@simonjayhawkins
Copy link
Member

duplicate of #29622 and #28125

@simonjayhawkins simonjayhawkins added Duplicate Report Duplicate issue or pull request and removed Unreliable Test Unit tests that occasionally fail labels Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate Report Duplicate issue or pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TomAugspurger @jbrockmendel @simonjayhawkins @JvPy @ShaharNaveh