Skip to content

REF: Rework core.dtypes.cast.maybe_promote #18396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattayes opened this issue Nov 20, 2017 · 3 comments
Closed

REF: Rework core.dtypes.cast.maybe_promote #18396

mattayes opened this issue Nov 20, 2017 · 3 comments
Labels
Clean Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments

@mattayes
Copy link
Contributor

Problem description

xref #18313

note if you are interested in cleaning some things up :>

maybe_promote I think will pretty much ignore its fill value for almost all dtypes. So the question is, when is it not ignored, can we safely remove it (or really just make the default fill_value=None, and then when its not None actually do something.

Not sure of the answer here.

@mattayes
Copy link
Contributor Author

@jreback Could you expand on the options you're considering?

@jreback
Copy link
Contributor

jreback commented Nov 21, 2017

see how/when maybe_promote is called. I suspect we don't actually use the passed in fill arg. If so we can dispense with it. but maybe I am wrong and it is used. In that case, the default should be fill_value=None, just makes it more clear.

@jreback jreback added Clean Difficulty Intermediate Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Nov 21, 2017
@jreback jreback added this to the Next Major Release milestone Nov 21, 2017
@jbrockmendel
Copy link
Member

Closed by #28913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

No branches or pull requests

3 participants