Skip to content

Commit f2274d4

Browse files
committed
Add test for wrong category type
1 parent bb9589f commit f2274d4

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

pandas/core/indexes/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3036,11 +3036,11 @@ def _convert_scalar_indexer(self, key, kind=None):
30363036
"unicode",
30373037
"mixed",
30383038
]:
3039-
return self._invalid_indexer("label", key)
3039+
self._invalid_indexer("label", key)
30403040

30413041
elif kind in ["loc"] and is_integer(key):
30423042
if not self.holds_integer():
3043-
return self._invalid_indexer("label", key)
3043+
self._invalid_indexer("label", key)
30443044

30453045
return key
30463046

pandas/core/indexes/category.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -700,8 +700,7 @@ def _convert_scalar_indexer(self, key, kind=None):
700700
try:
701701
return self.categories._convert_scalar_indexer(key, kind=kind)
702702
except TypeError:
703-
self._invalid_indexer("label", key=key)
704-
703+
self._invalid_indexer("label", key)
705704
return super()._convert_scalar_indexer(key, kind=kind)
706705

707706
@Appender(_index_shared_docs["_convert_list_indexer"])

pandas/tests/indexing/test_categorical.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,13 @@ def test_loc_scalar(self):
8080
with pytest.raises(TypeError, match=msg):
8181
df.loc["d", "C"] = 10
8282

83+
msg = (
84+
r"cannot do label indexing on <class 'pandas\.core\.indexes\.category"
85+
r"\.CategoricalIndex'> with these indexers \[1\] of <class 'int'>"
86+
)
87+
with pytest.raises(TypeError, match=msg):
88+
df.loc[1]
89+
8390
def test_getitem_scalar(self):
8491

8592
cats = Categorical([Timestamp("12-31-1999"), Timestamp("12-31-2000")])

0 commit comments

Comments
 (0)