Skip to content

Commit e6a3f40

Browse files
committed
ENH: add dtype validation for value in StringArray.fillna
1 parent bc537b7 commit e6a3f40

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pandas/core/arrays/string_.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,8 @@ def __setitem__(self, key, value):
283283
super().__setitem__(key, value)
284284

285285
def fillna(self, value=None, method=None, limit=None):
286-
# TODO: validate dtype
286+
if not isinstance(value, str):
287+
raise TypeError(f"{value} is not a valid fill value; must be a string")
287288
return super().fillna(value, method, limit)
288289

289290
def astype(self, dtype, copy=True):

0 commit comments

Comments
 (0)