TYP: check_untyped_defs various (#30572)

Author: simonjayhawkins

pandas/compat/pickle_compat.py

@@ -169,9 +169,9 @@ def __new__(cls) -> "DataFrame":  # type: ignore
 
 
 # our Unpickler sub-class to override methods and some dispatcher
-# functions for compat
-
+# functions for compat and uses a non-public class of the pickle module.
 
+# error: Name 'pkl._Unpickler' is not defined
 class Unpickler(pkl._Unpickler):  # type: ignore
     def find_class(self, module, name):
         # override superclass

pandas/core/arrays/sparse/dtype.py

@@ -64,7 +64,7 @@ class SparseDtype(ExtensionDtype):
     # hash(nan) is (sometimes?) 0.
     _metadata = ("_dtype", "_fill_value", "_is_na_fill_value")
 
-    def __init__(self, dtype: Dtype = np.float64, fill_value: Any = None) -> None:
+    def __init__(self, dtype: Dtype = np.float64, fill_value: Any = None):
 
         if isinstance(dtype, type(self)):
             if fill_value is None:

pandas/core/config_init.py

@@ -300,14 +300,15 @@ def table_schema_cb(key):
     _enable_data_resource_formatter(cf.get_option(key))
 
 
-def is_terminal():
+def is_terminal() -> bool:
     """
     Detect if Python is running in a terminal.
 
     Returns True if Python is running in a terminal or False if not.
     """
     try:
-        ip = get_ipython()
+        # error: Name 'get_ipython' is not defined
+        ip = get_ipython()  # type: ignore
     except NameError:  # assume standard Python interpreter in a terminal
         return True
     else:

pandas/core/dtypes/generic.py

@@ -4,7 +4,10 @@
 # define abstract base classes to enable isinstance type checking on our
 # objects
 def create_pandas_abc_type(name, attr, comp):
-    @classmethod
+
+    # https://github.com/python/mypy/issues/1006
+    # error: 'classmethod' used with a non-method
+    @classmethod  # type: ignore
     def _check(cls, inst) -> bool:
         return getattr(inst, attr, "_typ") in comp
 

pandas/core/groupby/groupby.py

@@ -2540,9 +2540,9 @@ def get_groupby(
     squeeze: bool = False,
     observed: bool = False,
     mutated: bool = False,
-):
+) -> GroupBy:
 
-    klass: Union[Type["SeriesGroupBy"], Type["DataFrameGroupBy"]]
+    klass: Type[GroupBy]
     if isinstance(obj, Series):
         from pandas.core.groupby.generic import SeriesGroupBy
 

pandas/core/indexes/category.py

@@ -1,5 +1,5 @@
 import operator
-from typing import Any
+from typing import Any, List
 
 import numpy as np
 
@@ -583,6 +583,7 @@ def reindex(self, target, method=None, level=None, limit=None, tolerance=None):
 
         target = ibase.ensure_index(target)
 
+        missing: List[int]
         if self.equals(target):
             indexer = None
             missing = []

setup.cfg

@@ -181,15 +181,9 @@ check_untyped_defs=False
 [mypy-pandas.core.computation.scope]
 check_untyped_defs=False
 
-[mypy-pandas.core.config_init]
-check_untyped_defs=False
-
 [mypy-pandas.core.dtypes.cast]
 check_untyped_defs=False
 
-[mypy-pandas.core.dtypes.generic]
-check_untyped_defs=False
-
 [mypy-pandas.core.frame]
 check_untyped_defs=False
 
@@ -208,9 +202,6 @@ check_untyped_defs=False
 [mypy-pandas.core.indexes.base]
 check_untyped_defs=False
 
-[mypy-pandas.core.indexes.category]
-check_untyped_defs=False
-
 [mypy-pandas.core.indexes.datetimelike]
 check_untyped_defs=False
 
@@ -256,9 +247,6 @@ check_untyped_defs=False
 [mypy-pandas.core.reshape.reshape]
 check_untyped_defs=False
 
-[mypy-pandas.core.series]
-check_untyped_defs=False
-
 [mypy-pandas.core.strings]
 check_untyped_defs=False