Parametrize value_counts test

Author: tomspur

pandas/tests/test_algos.py

@@ -962,27 +962,21 @@ def test_value_counts_uint64(self):
         if not compat.is_platform_32bit():
             tm.assert_series_equal(result, expected)
 
-    def test_value_counts_nonsorted_single_occurance(self):
+    @pytest.mark.parametrize("sort", [True, False])
+    def test_value_counts_single_occurance(self, sort):
         # GH 12679
+        if sort == True:
+            pytest.xfail(reason="sort=True does not guarantee the same order")
+
         # All items occour exactly once.
         # No matter if sorted or not, the resulting values should be in
         # the same order.
         s = Series(list('bacdef'))
 
         # Guarantee the same index if value_counts(sort=False) is used
-        vc = s.value_counts(sort=False, ascending=False)
-        tm.assert_series_equal(Series(vc.index), s)
-        vc = s.value_counts(sort=False, ascending=True)
-        tm.assert_series_equal(Series(vc.index), s)
-
-    @pytest.mark.xfail(reason="sort=True does not guarantee the same order")
-    def test_value_counts_sorted_single_occurance(self):
-        # GH 12679
-        s = Series(list('bacdef'))
-        # Guarantee does not hold yet for the sort=True case
-        vc = s.value_counts(sort=True, ascending=False)
+        vc = s.value_counts(sort=sort, ascending=False)
         tm.assert_series_equal(Series(vc.index), s)
-        vc = s.value_counts(sort=True, ascending=True)
+        vc = s.value_counts(sort=sort, ascending=True)
         tm.assert_series_equal(Series(vc.index), s)
 
     def test_value_counts_nonsorted_double_occurance(self):