BUG: Fix Series.sort_values descending & mergesort

The solution uses the `nargsort` function, which was created to handle
in one place the intricacies of sorting. Not adapting Series.sort_values
to use may have been an oversight.

closes #28697

Author: has2k1

doc/source/whatsnew/v0.25.2.rst

@@ -102,6 +102,9 @@ Other
 - Compatibility with Python 3.8 in :meth:`DataFrame.query` (:issue:`27261`)
 - Fix to ensure that tab-completion in an IPython console does not raise
   warnings for deprecated attributes (:issue:`27900`).
+- Bug in :meth:`Series.sort_values` when ``ascending`` is set to ``False`` and
+  ``kind`` is set to ``mergesort`` (:issue:`28697`)
+
 
 .. _whatsnew_0.252.contributors:
 

pandas/core/series.py

@@ -75,6 +75,7 @@
 from pandas.core.indexes.timedeltas import TimedeltaIndex
 from pandas.core.indexing import check_bool_indexer
 from pandas.core.internals import SingleBlockManager
+from pandas.core.sorting import nargsort
 from pandas.core.strings import StringMethods
 from pandas.core.tools.datetimes import to_datetime
 
@@ -3066,26 +3067,6 @@ def sort_values(
                 "sort in-place you must create a copy"
             )
 
-        def _try_kind_sort(arr):
-            # easier to ask forgiveness than permission
-            try:
-                # if kind==mergesort, it can fail for object dtype
-                return arr.argsort(kind=kind)
-            except TypeError:
-                # stable sort not available for object dtype
-                # uses the argsort default quicksort
-                return arr.argsort(kind="quicksort")
-
-        arr = self._values
-        sortedIdx = np.empty(len(self), dtype=np.int32)
-
-        bad = isna(arr)
-
-        good = ~bad
-        idx = ibase.default_index(len(self))
-
-        argsorted = _try_kind_sort(arr[good])
-
         if is_list_like(ascending):
             if len(ascending) != 1:
                 raise ValueError(
@@ -3097,21 +3078,11 @@ def _try_kind_sort(arr):
         if not is_bool(ascending):
             raise ValueError("ascending must be boolean")
 
-        if not ascending:
-            argsorted = argsorted[::-1]
-
-        if na_position == "last":
-            n = good.sum()
-            sortedIdx[:n] = idx[good][argsorted]
-            sortedIdx[n:] = idx[bad]
-        elif na_position == "first":
-            n = bad.sum()
-            sortedIdx[n:] = idx[good][argsorted]
-            sortedIdx[:n] = idx[bad]
-        else:
-            raise ValueError("invalid na_position: {!r}".format(na_position))
+        indexer = nargsort(
+            self._values, kind=kind, ascending=ascending, na_position=na_position
+        )
 
-        result = self._constructor(arr[sortedIdx], index=self.index[sortedIdx])
+        result = self._constructor(self.iloc[indexer], index=self.index[indexer])
 
         if inplace:
             self._update_inplace(result)

pandas/tests/series/test_sorting.py

@@ -86,6 +86,12 @@ def test_sort_values(self):
         with pytest.raises(ValueError, match=msg):
             s.sort_values(inplace=True)
 
+        # mergesort and ascending=False
+        ser = Series([1, 2, 1, 3], ["first", "b", "second", "c"])
+        expected = Series([3, 2, 1, 1], ["c", "b", "first", "second"])
+        result = ser.sort_values(ascending=False, kind="mergesort")
+        tm.assert_series_equal(expected, result)
+
     def test_sort_index(self):
         rindex = list(self.ts.index)
         random.shuffle(rindex)