Skip to content

Commit b6ae6e8

Browse files
loicdiridolloukroche98brzegorzTescoDr-Irv
authored
GH1051 Drop astype tests for Mac arm for float128 and complex256 (#1057)
* GH1051 Drop astype tests for Mac arm for float128 and complex256 * Fix * Fix * Test fix * Move to macos-latest * Update test.yml * GH1051 Lock in tables version to 3.10.1 * GH1049 Deprecate Index and Grouper methods for 2.0 migration (#1050) * GH1049 Deprecate Index and Grouper methods for migration to 2.0 * GH1049 Deprecate use_nullable_dtypes in read_parquet * Change signature of StringMethods.rsplit to match pandas (#1056) * GH1053 @ for DataFrame, eval in place for DataFrame, test migrations (#1054) * GH1053 @ for DataFrame, eval in place for DataFrame, test migrations * Formatting and spelling * GH1053 PR Feedback * GH1053 Formatting * GH1043 Update _typing.pyi: add "cross" option to JoinHow (#1044) * Update _typing.pyi: add "cross" option to JoinHow * Removed "cross" option from JoinHow and added it back to MergeHow * Replaced JoinHow with MergeHow in frame.join * Added a test for join "how" * Update test_frame.py: used check(assert_type pattern in unit test * Update test_frame.py Fix formatting * Version 2.2.3.241126 --------- Co-authored-by: kroche98 <[email protected]> Co-authored-by: brzegorzTesco <[email protected]> Co-authored-by: Irv Lustig <[email protected]>
1 parent 7f06ab1 commit b6ae6e8

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
# Don't use macos-latest because it is arm64
21-
os: [ubuntu-latest, windows-latest, macos-13]
20+
# macos-latest is arm
21+
os: [ubuntu-latest, windows-latest, macos-latest]
2222
python-version: ["3.10", "3.11", "3.12"]
2323

2424
name: OS ${{ matrix.os }} - Python ${{ matrix.python-version }}

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ black = ">=23.3.0"
4747
isort = ">=5.12.0"
4848
openpyxl = ">=3.0.10"
4949
# for tables, MacOS gives random CI failures on 3.9.2
50-
tables = { version = "==3.9.2", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4
50+
tables = { version = "==3.10.1", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4
5151
lxml = ">=4.9.1"
5252
pyreadstat = ">=1.2.0"
5353
xlrd = ">=2.0.1"

tests/test_series.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2429,6 +2429,15 @@ def test_astype_float(cast_arg: FloatDtypeArg, target_type: type) -> None:
24292429
s.astype(cast_arg)
24302430
pytest.skip("Windows does not support float128")
24312431

2432+
if (
2433+
platform.system() == "Darwin"
2434+
and platform.processor() == "arm"
2435+
and cast_arg in ("f16", "float128")
2436+
):
2437+
with pytest.raises(TypeError):
2438+
s.astype(cast_arg)
2439+
pytest.skip("MacOS arm does not support float128")
2440+
24322441
check(s.astype(cast_arg), pd.Series, target_type)
24332442

24342443
if TYPE_CHECKING:
@@ -2482,6 +2491,15 @@ def test_astype_complex(cast_arg: ComplexDtypeArg, target_type: type) -> None:
24822491
s.astype(cast_arg)
24832492
pytest.skip("Windows does not support complex256")
24842493

2494+
if (
2495+
platform.system() == "Darwin"
2496+
and platform.processor() == "arm"
2497+
and cast_arg in ("c32", "complex256")
2498+
):
2499+
with pytest.raises(TypeError):
2500+
s.astype(cast_arg)
2501+
pytest.skip("MacOS arm does not support complex256")
2502+
24852503
check(s.astype(cast_arg), pd.Series, target_type)
24862504

24872505
if TYPE_CHECKING:

0 commit comments

Comments
 (0)