Status update triggers reconciliation with finalizers disabled

[shawkins]

Bug Report

When using @Controller(finalizerName = Controller.NO_FINALIZER) an update to just the status of the primary resource will itself cause another reconciliation - which is a fairly tight processing loop. With the finalizer enabled no event loop is seen.

What did you expect to see?

The status update will not trigger an immediate reconciliation.

What did you see instead? Under which circumstances?

Operator sdk version 1.9.6 via the 2.0.0.Beta5 quarkus extension.

Environment

Openshift 4.8

[shawkins]

@metacosm @lburgazzoli this may have been addressed with #457 I'm not entirely sure.

Until that change, the check at https://github.com/java-operator-sdk/java-operator-sdk/blob/ccf305301d8f9e9e88f31cd492def656f3453241/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java#L131 will prevent a resource without a finalizer from updating the cache of generations seen, so the controller will immediately process an update event due to only a status change.

[shawkins]

I tried upgrading just the sdk dependency to 1.9.8 and confirmed that things worked as expected.

[csviri]

Hi @shawkins , thank you for the report!
The finalizer should not be relevant to this.
The status update, although its a subresource, updates the custom resource also in sense, that the resourceVersion is updated for example. So naturally an event should be received. However to prevent reconciliation we filter on metadata.generation, in this case the generation is not increased and (if this not turned explicitly off) the reconciliation should not happen as you mention.

Do I understand correctly that it work as expected in a more recent version and we can close the issue?

[shawkins]

Do I understand correctly that it work as expected in a more recent version and we can close the issue?

If you are good with the explanation of why it was occurring and what has addressed it, yes it can be closed.

[csviri]

Will add an integration test regarding to this case.