Skip to content

Workflow feature switch if we should throw aggregate exception on error. #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Apr 8, 2024 · 0 comments · Fixed by #2363
Closed

Workflow feature switch if we should throw aggregate exception on error. #2335

csviri opened this issue Apr 8, 2024 · 0 comments · Fixed by #2363
Labels
workflows
Milestone
5.0

Comments

@csviri
Copy link
Collaborator

csviri commented Apr 8, 2024 •
edited
Loading

Currently it is done automatically but some might want to access to error and see what went wrong:

java-operator-sdk/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

Line 151 in 3f442a1

res.throwAggregateExceptionIfErrorsPresent();

This is especially true for cleanup, since the ErrorStatusHandler is not handling the cleanup errors atm.
@csviri csviri added this to the 5.0 milestone Apr 8, 2024
@csviri csviri linked a pull request Apr 24, 2024 that will close this issue
feat: silent exception handling in managed workflows #2363
Merged
@csviri csviri closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
workflows
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

feat: silent exception handling in managed workflows operator-framework/java-operator-sdk
1 participant
@csviri