Skip to content

Configurable LeaderCallbacks #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r57 opened this issue Aug 9, 2023 · 2 comments · Fixed by #2015
Closed

Configurable LeaderCallbacks #2009

r57 opened this issue Aug 9, 2023 · 2 comments · Fixed by #2015
Assignees
Labels
Milestone

Comments

@r57
Copy link

r57 commented Aug 9, 2023

When setting up the leader election it would be great to be able to provide own LeaderCallbacks.

Use case
I'm required to integrate with health monitoring system and send regular hearth beats upstream with interval dictated by the system to the endpoint dictated by the system. So in HA setup I'm thinking only leader should manage this and persist the information in some object so any new elected leader can just carry on. But currently there's no way to tell if the running instance is actually leading or not.

@csviri csviri added this to the 4.5 milestone Aug 9, 2023
@csviri
Copy link
Collaborator

csviri commented Aug 9, 2023

Makes sense to me, can add this into next minor release.

@csviri csviri added the feature label Aug 9, 2023
@csviri csviri self-assigned this Aug 9, 2023
@csviri csviri linked a pull request Aug 11, 2023 that will close this issue
@csviri
Copy link
Collaborator

csviri commented Aug 11, 2023

@r57 added a PR, please take a look, if this is something that you thought of

@csviri csviri closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants