Skip to content

Remove remove flag to compare labels & annotation from GenericKubernetesResourceMatcher #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Jun 23, 2023 · 3 comments · Fixed by #2273
Closed

Remove remove flag to compare labels & annotation from GenericKubernetesResourceMatcher #1965

csviri opened this issue Jun 23, 2023 · 3 comments · Fixed by #2273
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
5.0

Comments

@csviri
Copy link
Collaborator

csviri commented Jun 23, 2023

Those should be always compared now based on the default updateMatcher implementation
@csviri csviri added this to the 5.0 milestone Jun 23, 2023
@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Jun 28, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 28, 2023
@csviri csviri removed the stale label Aug 28, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 28, 2023
@openshift-ci openshift-ci bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed stale labels Nov 8, 2023
@csviri csviri removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 13, 2024
@csviri csviri removed the stale label Jan 13, 2024
@csviri csviri linked a pull request Mar 8, 2024 that will close this issue
improve: matcher always considers metadata #2273
Merged
@csviri csviri closed this as completed Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

improve: matcher always considers metadata operator-framework/java-operator-sdk
2 participants
@csviri @openshift-ci-robot