Skip to content

Use Sever Side Apply to Update Status and Manage Finalizers #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Jun 5, 2023 · 5 comments · Fixed by #2278 or #2305
Closed

Use Sever Side Apply to Update Status and Manage Finalizers #1931

csviri opened this issue Jun 5, 2023 · 5 comments · Fixed by #2278 or #2305
Assignees
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented Jun 5, 2023

Currently this is not done by SSA.

@csviri csviri added this to the 5.0 milestone Jun 5, 2023
@csviri csviri added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 5, 2023
@csviri csviri removed the stale label Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 7, 2023
@csviri csviri removed the stale label Oct 9, 2023
Copy link

github-actions bot commented Dec 9, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 9, 2023
@csviri csviri removed kind/feature Categorizes issue or PR as related to a new feature. stale labels Dec 9, 2023
Copy link

github-actions bot commented Feb 8, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Feb 8, 2024
@csviri csviri removed the stale label Feb 8, 2024
@csviri
Copy link
Collaborator Author

csviri commented Mar 8, 2024

This would make more sense if the status would be written by multiple controllers, usually, that is not the case. Was checking, and neither the Kubernetes built-in operators seems to be using SSA to update the status. On the other hand this is true also for the manager resource specs. So might at the end it would be nicer to do with SSA.

For the resource update (not the status) also a little bit problematic, with SSA we just should send the intent, not the whole resource, so that might be confusing for the users that not the primary resource from the reconciler argument should be used, rather there should be the resource created from scratch and only the changes on the resource should be applied.

So what would make sense is to do is make it default for patch (with a feature flag to not do it by default), and an explicit method to path the resource with SSA - where in javadoc we articulate that only the intent should be sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment