Skip to content

Remove crd-generator-api Dependency After CRD Generator Fix in Fabric8 Client #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Jul 25, 2022 · 1 comment · Fixed by #1439
Closed

Remove crd-generator-api Dependency After CRD Generator Fix in Fabric8 Client #1369

csviri opened this issue Jul 25, 2022 · 1 comment · Fixed by #1439
Assignees
@csviri
Labels
fabric8
Milestone
3.2

Comments

@csviri
Copy link
Collaborator

csviri commented Jul 25, 2022 •
edited
Loading

As a workaround for issue in CRD generator for fabric8 client v6:
fabric8io/kubernetes-client#4256

had to add dependencies for crd-generator-api, like:

https://github.com/java-operator-sdk/java-operator-sdk/blob/d74559a5a87d82b00dbf993f53d9040b81b925a9/sample-operators/mysql-schema/pom.xml#L50-L53

after this issue is fixed in fabric8 client (in v6.1) , those should be removed
@csviri csviri added this to the 3.2 milestone Jul 25, 2022
@csviri csviri added the fabric8 label Jul 25, 2022
@csviri
Copy link
Collaborator Author

csviri commented Jul 27, 2022

see: fabric8io/kubernetes-client#4302

@csviri csviri self-assigned this Sep 2, 2022
@csviri csviri linked a pull request Sep 2, 2022 that will close this issue
fix: remove crd-generator-api dependencies #1439
Merged
@csviri csviri closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csviri csviri

Labels
fabric8
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

fix: remove crd-generator-api dependencies operator-framework/java-operator-sdk
1 participant
@csviri