Skip to content

Improved out of the box SecondaryToPrimary mapping for KubernetesDependentResource. #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Apr 19, 2022 · 1 comment · Fixed by #1197
Closed

Improved out of the box SecondaryToPrimary mapping for KubernetesDependentResource. #1165

csviri opened this issue Apr 19, 2022 · 1 comment · Fixed by #1197
Assignees

Comments

@csviri
Copy link
Collaborator

csviri commented Apr 19, 2022

@csviri csviri changed the title KubernetesDependentResource should log warning if owner reference not added but PrimaryToSecondaryMapper is not implemented KubernetesDependentResource should log warning if owner reference not added but SecondaryToPrimaryMapper is not implemented Apr 19, 2022
@csviri csviri self-assigned this Apr 19, 2022
@csviri
Copy link
Collaborator Author

csviri commented Apr 22, 2022

Discussed this on weekly, we could also approach this problem in a different way. That Kubernetes dependent resource might support in addition to owner reference handling also adding labels if the owner reference cannot be added (resources are in different namespace).

Basically with these two different approaches we cover every case. So should be supported out of the box. But also there should be a possibility for a custom approach.

@csviri csviri changed the title KubernetesDependentResource should log warning if owner reference not added but SecondaryToPrimaryMapper is not implemented Improved out of the box SecondaryToPrimary mapping for KubernetesDependentResource. Apr 22, 2022
@csviri csviri closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant