refactor: restore LifecycleAware compatibility

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

@@ -34,10 +34,10 @@ public void init(LeaderElectionConfiguration config, KubernetesClient client) {
     // releaseOnCancel is not used in the underlying implementation
     leaderElector = new LeaderElectorBuilder(client,
         ConfigurationServiceProvider.instance().getExecutorService())
-            .withConfig(
-                new LeaderElectionConfig(lock, config.getLeaseDuration(), config.getRenewDeadline(),
-                    config.getRetryPeriod(), leaderCallbacks(), true, config.getLeaseName()))
-            .build();
+        .withConfig(
+            new LeaderElectionConfig(lock, config.getLeaseDuration(), config.getRenewDeadline(),
+                config.getRetryPeriod(), leaderCallbacks(), true, config.getLeaseName()))
+        .build();
   }
 
   public boolean isLeaderElectionEnabled() {

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

@@ -45,7 +45,7 @@
 @SuppressWarnings({"unchecked", "rawtypes"})
 @Ignore
 public class Controller<P extends HasMetadata>
-    implements Reconciler<P>, Cleaner<P>,
+    implements Reconciler<P>, LifecycleAware, Cleaner<P>,
     RegisteredController<P> {
 
   private static final Logger log = LoggerFactory.getLogger(Controller.class);
@@ -263,6 +263,10 @@ public MixedOperation<P, KubernetesResourceList<P>, Resource<P>> getCRClient() {
     return kubernetesClient.resources(configuration.getResourceClass());
   }
 
+  public void start() throws OperatorException {
+    start(true);
+  }
+
   /**
    * Registers the specified controller with this operator, overriding its default configuration by
    * the specified one (usually created via

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/ControllerTest.java

@@ -24,7 +24,7 @@ void crdShouldNotBeCheckedForNativeResources() {
     final var configuration = MockControllerConfiguration.forResource(Secret.class);
 
     final var controller = new Controller<Secret>(reconciler, configuration, client);
-    controller.start(true);
+    controller.start();
     verify(client, never()).apiextensions();
   }
 
@@ -36,7 +36,7 @@ void crdShouldNotBeCheckedForCustomResourcesIfDisabled() {
     try {
       ConfigurationServiceProvider.overrideCurrent(o -> o.checkingCRDAndValidateLocalModel(false));
       final var controller = new Controller<TestCustomResource>(reconciler, configuration, client);
-      controller.start(true);
+      controller.start();
       verify(client, never()).apiextensions();
     } finally {
       ConfigurationServiceProvider.reset();

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcherTest.java

@@ -121,7 +121,7 @@ public boolean useFinalizer() {
         return useFinalizer;
       }
     };
-    controller.start(true);
+    controller.start();
 
     return new ReconciliationDispatcher<>(controller, customResourceFacade);
   }