-
Notifications
You must be signed in to change notification settings - Fork 28
Support revisions on global commands #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We could require |
That feels odd, I associate |
considering square brackets in diagnostics are rare and you could always use a longer or regex pattern in that case (and get an error if that |
I forgot, do we even still have the no-error-level syntax? |
oh haha, no I scrapped that and added a global min-level flag to get the "don't require annotaitons for all notes" behaviour. Ok no ambiguity, woo |
Right so the only question is if we want to incur all that churn for when/if rustc itself uses this crate. |
I can incrementally move the rustc test suite to use the same syntax to keep the final diff small |
From what I could tell, revisions are currently only supported on error patterns. Would be nice to also support them on global commands, so that one can do things like
FWIW I would have probably picked this syntax
but that would be inconsistent with
//[fn_ptr]~^ ERROR: pattern
... maybe we should change that to//~[fn_ptr]^ ERROR: pattern
, too, so that the first character after the//
always indicates what this is?OTOH, that might create parsing ambiguities if there is no ERROR level, and
//[revision]
is also consistent, so... whatever.The text was updated successfully, but these errors were encountered: