Skip to content

Commit bd5fbfd

Browse files
KunWuChanojeda
authored andcommitted
rust: page:: optimize rust symbol generation for Page
When build the kernel using the llvm-18.1.3-rust-1.85.0-x86_64 with ARCH=arm64, the following symbols are generated: $nm vmlinux | grep ' _R'.*Page | rustfilt ffff8000805b6f98 T <kernel::page::Page>::alloc_page ffff8000805b715c T <kernel::page::Page>::fill_zero_raw ffff8000805b720c T <kernel::page::Page>::copy_from_user_slice_raw ffff8000805b6fb4 T <kernel::page::Page>::read_raw ffff8000805b7088 T <kernel::page::Page>::write_raw ffff8000805b72fc T <kernel::page::Page as core::ops::drop::Drop>::drop These Rust symbols(alloc_page and drop) are trivial wrappers around the C functions alloc_pages and __free_pages. It doesn't make sense to go through a trivial wrapper for these functions, so mark them inline. Link: Rust-for-Linux#1145 Suggested-by: Alice Ryhl <[email protected]> Co-developed-by: Grace Deng <[email protected]> Signed-off-by: Grace Deng <[email protected]> Signed-off-by: Kunwu Chan <[email protected]> Reviewed-by: Alice Ryhl <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>
1 parent 92a09c4 commit bd5fbfd

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

rust/kernel/page.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ impl Page {
6969
/// let page = Page::alloc_page(GFP_KERNEL | __GFP_ZERO)?;
7070
/// # Ok::<(), kernel::alloc::AllocError>(())
7171
/// ```
72+
#[inline]
7273
pub fn alloc_page(flags: Flags) -> Result<Self, AllocError> {
7374
// SAFETY: Depending on the value of `gfp_flags`, this call may sleep. Other than that, it
7475
// is always safe to call this method.
@@ -251,6 +252,7 @@ impl Page {
251252
}
252253

253254
impl Drop for Page {
255+
#[inline]
254256
fn drop(&mut self) {
255257
// SAFETY: By the type invariants, we have ownership of the page and can free it.
256258
unsafe { bindings::__free_pages(self.page.as_ptr(), 0) };

0 commit comments

Comments
 (0)