Skip to content

Commit ffadf35

Browse files
committed
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC. PR-URL: #47251 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matteo Collina <[email protected]> PR-URL: #58070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1 parent 57699ff commit ffadf35

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.7',
41+
'v8_embedder_string': '-node.8',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/base/macros.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -442,9 +442,9 @@ bool is_inbounds(float_t v) {
442442
// Setup for Windows shared library export.
443443
#define V8_EXPORT_ENUM
444444
#ifdef BUILDING_V8_SHARED_PRIVATE
445-
#define V8_EXPORT_PRIVATE __declspec(dllexport)
445+
#define V8_EXPORT_PRIVATE
446446
#elif USING_V8_SHARED_PRIVATE
447-
#define V8_EXPORT_PRIVATE __declspec(dllimport)
447+
#define V8_EXPORT_PRIVATE
448448
#else
449449
#define V8_EXPORT_PRIVATE
450450
#endif // BUILDING_V8_SHARED
@@ -454,7 +454,7 @@ bool is_inbounds(float_t v) {
454454
// Setup for Linux shared library export.
455455
#if V8_HAS_ATTRIBUTE_VISIBILITY && \
456456
(defined(BUILDING_V8_SHARED_PRIVATE) || USING_V8_SHARED_PRIVATE)
457-
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
457+
#define V8_EXPORT_PRIVATE
458458
#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE
459459
#else
460460
#define V8_EXPORT_PRIVATE

0 commit comments

Comments
 (0)