fixup: move the validation into process.exitCode

Signed-off-by: Daeyeon Jeong [email protected]

Author: daeyeon

lib/internal/bootstrap/node.js

@@ -44,6 +44,7 @@ const {
   ArrayPrototypeFill,
   FunctionPrototypeCall,
   JSONParse,
+  Number,
   ObjectDefineProperty,
   ObjectGetPrototypeOf,
   ObjectPreventExtensions,
@@ -60,6 +61,9 @@ const {
   deprecate,
   exposeInterface,
 } = require('internal/util');
+const {
+  validateInteger,
+} = require('internal/validators');
 
 setupProcessObject();
 
@@ -69,6 +73,27 @@ setupBuffer();
 process.domain = null;
 process._exiting = false;
 
+{
+  let exitCode;
+  ObjectDefineProperty(process, 'exitCode', {
+    __proto__: null,
+    get() {
+      return exitCode;
+    },
+    set(code) {
+      if (code !== null && code !== undefined) {
+        validateInteger(
+          typeof code === 'string' && code !== '' ? Number(code) : code,
+          'code'
+        );
+      }
+      exitCode = code;
+    },
+    enumerable: true,
+    configurable: true,
+  });
+}
+
 // process.config is serialized config.gypi
 const nativeModule = internalBinding('native_module');
 

lib/internal/process/per_thread.js

@@ -13,7 +13,6 @@ const {
   ArrayPrototypeSplice,
   BigUint64Array,
   Float64Array,
-  Number,
   NumberMAX_SAFE_INTEGER,
   ObjectFreeze,
   ReflectApply,
@@ -44,7 +43,6 @@ const {
 const format = require('internal/util/inspect').format;
 const {
   validateArray,
-  validateInteger,
   validateNumber,
   validateObject,
 } = require('internal/validators');
@@ -184,10 +182,6 @@ function wrapProcessMethods(binding) {
     process.off('exit', handleProcessExit);
 
     if (code !== null && code !== undefined) {
-      validateInteger(
-        typeof code === 'string' && code !== '' ? Number(code) : code,
-        'code',
-      );
       process.exitCode = code;
     }