Skip to content

Commit 24c93f2

Browse files
committed
test: temporarily skip flaky test on freebsd
The final segment of the test_object/test.js fails for some as yet unknown reason, only on freebsd, with this PR, despite the test being completely unrelated to the test. This temporarily skips the segment on freebsd until the cause can be determined. Signed-off-by: James M Snell <[email protected]>
1 parent 99f1670 commit 24c93f2

File tree

1 file changed

+10
-0
lines changed
  • test/js-native-api/test_object

1 file changed

+10
-0
lines changed

test/js-native-api/test_object/test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,16 @@ assert.deepStrictEqual(test_object.TestGetProperty(), {
296296
obj.x = 'd';
297297
}
298298

299+
// TODO(@jasnell): For some reason that is as yet unknown,
300+
// https://github.com/nodejs/node/pull/37786, which makes the
301+
// atob and btoa functions global, causes this test to fail
302+
// persistently on FreeBSD, and only on FreeBSD, despite the
303+
// fact that https://github.com/nodejs/node/pull/37786 does
304+
// not touch anything that should impact this test and this
305+
// test does not use atob or btoa at all.
306+
if (common.isFreeBSD)
307+
common.skip('Skips bits that are failing on FreeBSD for no obvious reason.');
308+
299309
{
300310
const obj = { x: 10, y: 10, z: 10 };
301311

0 commit comments

Comments
 (0)