Skip to content

Commit 955b3ad

Browse files
committed
fixing _check_version_requirements, so it also checks maximal version
1 parent 6d65cbb commit 955b3ad

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

nipype/interfaces/base/core.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,8 +411,12 @@ def _check_version_requirements(self, trait_object, raise_exception=True):
411411
raise Exception(
412412
'Trait %s (%s) (version %s < required %s)' %
413413
(name, self.__class__.__name__, version, min_ver))
414-
check = dict(max_ver=lambda t: t is not None)
415-
names = trait_object.trait_names(**check)
414+
415+
# check maximum version
416+
check = dict(max_ver=lambda t: t is not None)
417+
names = trait_object.trait_names(**check)
418+
if names and self.version:
419+
version = LooseVersion(str(self.version))
416420
for name in names:
417421
max_ver = LooseVersion(
418422
str(trait_object.traits()[name].max_ver))

0 commit comments

Comments
 (0)