Skip to content

singularity not writing finished without errors message to stderr in 20.1.0 #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmd opened this issue Jun 3, 2020 · 5 comments
Closed

Comments

@dmd
Copy link

dmd commented Jun 3, 2020

Every successful job we've run (which is all of them except those mentioned in #2161 ) using singularity container 20.1.0 has written nothing at all to stderr.

That means we don't get the "fMRIPrep finished without errors" message written anywhere.

@dmd dmd added the bug label Jun 3, 2020
@dmd dmd changed the title singularity not writing to stderr in 20.1.0 (?) singularity not writing finished without errors message to stderr in 20.1.0 Jun 3, 2020
@oesteban
Copy link
Member

oesteban commented Jun 3, 2020

fMRIPrep finished successfully! should be printed to stdout:

https://github.com/poldracklab/fmriprep/blob/eb3a40b827d277ce661e31c27f6ace40ef3c2be6/fmriprep/cli/run.py#L114

Can you check?

@dmd
Copy link
Author

dmd commented Jun 3, 2020

Aha! You changed the output stream and the wording! I was grepping for (and my code was expecting) fMRIPrep finished without errors.

@dmd dmd closed this as completed Jun 3, 2020
@dmd
Copy link
Author

dmd commented Jun 3, 2020

(Oh, ugh. This means my code has to handle both phrases and both possible files, since some people pin their fmriprep version at older versions.)

@oesteban
Copy link
Member

oesteban commented Jun 3, 2020

Sorry about this. Maybe worth documenting this kind of details in our draft for how fmriprep uses version numbers (www.nipreps.org/devs/releases/). Something to mention that important signals in the log file and changes to where (std out/err) things are logged may grant a minor version bump. What do you think?

@dmd
Copy link
Author

dmd commented Jun 3, 2020

Yeah. If people (like me) are building tooling around fmriprep, it's important to at least know when stuff like that changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants