Skip to content

Have a way to retrieve the original error on defunct connection ? #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prevostc opened this issue Aug 20, 2020 · 6 comments
Closed

Have a way to retrieve the original error on defunct connection ? #463

prevostc opened this issue Aug 20, 2020 · 6 comments

Comments

@prevostc
Copy link

Suggestion

I noticed the _set_defunct method of the bolt protocol files completely hides the underlying error message:

In my case I get a OSError from IncomingMessage:

When I get this "Failed to read from defunct connection" error, I don't really know what to do and have absolutely no way to retrieve the original error for hints.

@martin-neotech
Copy link
Contributor

@prevostc Thanks for the suggestion, I will have a look at this, to improve error propagation for this case.

@martin-neotech
Copy link
Contributor

#466

@martin-neotech
Copy link
Contributor

@prevostc does the PR solve your issue with the error propagation info? I will do a patch release on Thursday where this is included.

@prevostc
Copy link
Author

prevostc commented Aug 25, 2020

@martin-neotech thank you for your quick work and great communication. I'll try the branch with the fix and will let you know today.

@prevostc
Copy link
Author

Sorry for the delay, I can confirm this fix for my particular issue

@martin-neotech
Copy link
Contributor

great news, thanks for the feedback.

Cheers, Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants