IsIn condition with empty list is not rendered, and selects the entire table

[franck102]

I have found this issue that discusses the problem:
[https://github.com//issues/228]

... however I don't understand if or how the issue was resolved. The documentation mentions a NonRenderingWhereClauseException that should be thrown with the default configuration, however this is not the behavior I am seeing with org.mybatis.dynamic-sql:mybatis-dynamic-sql:1.4.1: the condition is simply dropped and the entire table is returned.
Looking through the source code of the IsIn class I don't see that exception being used anywhere... am I missing something? I tried explicitly setting nonRenderingWhereClauseAllowed to true in a global config file and that didn't make any difference.

Above all, why can't IsIn() simply be rendered as "WHERE FALSE"??? This seems like the natural, safe, easy thing to do?

[jeffgbutler]

The exception is thrown when a where clause fails to render. You can see the code here:

mybatis-dynamic-sql/src/main/java/org/mybatis/dynamic/sql/where/render/WhereRenderer.java

Lines 53 to 57 in ef3769e

	if (whereClause.isPresent() || whereModel.isNonRenderingClauseAllowed()) {
	return whereClause;
	} else {
	throw new NonRenderingWhereClauseException();
	}

If you have found a case where this isn't working, please post the failing code so we can fix it.

[jeffgbutler]

Closing as there is no response. Please feel free to reopen if you find a bug.